Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added an AssetGrid/Timeline to map page.
By default the grid is closed to avoid loading a large set of timebuckets and images.
When Grid is opened it updates when map is zoomed or relocated.
Implements feature #4519
Code partly from discussion #11893
Did not add an option to mapsettings. The grid is always available (but closed).
Next steps:
Show App Bar, when images are selected in grid. Right now nothing happens on selecting images.
Show images from the same timeframe as the current images shown in grid. This could be useful when shooting with a phone (geolocation is set) and a mirrorless camera (without geolocation).
How Has This Been Tested?
Manually tested with 6000 geolocated images and around 1300 images per location.
Screenshots (if appropriate)
API Changes
api/timeline/buckets and api/timeline/bucket accept coordinates as x1, x2, y1, y2 parameters
updated TimeBucketDto
Checklist:
src/services
uses repositories implementations for database calls, filesystem operations, etc. (no new code)src/repositories/
is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services
) (no new code)