Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AssetGrid/Timeline to Map #16494

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Added AssetGrid/Timeline to Map #16494

wants to merge 7 commits into from

Conversation

RBedbur
Copy link

@RBedbur RBedbur commented Mar 2, 2025

Description

Added an AssetGrid/Timeline to map page.
By default the grid is closed to avoid loading a large set of timebuckets and images.
When Grid is opened it updates when map is zoomed or relocated.

Implements feature #4519

Code partly from discussion #11893

Did not add an option to mapsettings. The grid is always available (but closed).

Next steps:
Show App Bar, when images are selected in grid. Right now nothing happens on selecting images.
Show images from the same timeframe as the current images shown in grid. This could be useful when shooting with a phone (geolocation is set) and a mirrorless camera (without geolocation).

How Has This Been Tested?

Manually tested with 6000 geolocated images and around 1300 images per location.

Screenshots (if appropriate)

image image

API Changes

api/timeline/buckets and api/timeline/bucket accept coordinates as x1, x2, y1, y2 parameters
updated TimeBucketDto

Checklist:

  • [X ] I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • [ X] I have no unrelated changes in the PR.
  • [X ] I have confirmed that any new dependencies are strictly necessary. (no new dependencies)
  • I have written tests for new code (if applicable)
  • [X ] I have followed naming conventions/patterns in the surrounding code
  • [ X] All code in src/services uses repositories implementations for database calls, filesystem operations, etc. (no new code)
  • [ X] All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services) (no new code)

@RBedbur RBedbur requested a review from danieldietzler as a code owner March 2, 2025 16:27
Copy link
Contributor

github-actions bot commented Mar 2, 2025

Label error. Requires exactly 1 of: changelog:.*. Found: . A maintainer will add the required label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant