-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mobile): the page for adding photos to the album cannot be navigated back using gestures #16449
base: main
Are you sure you want to change the base?
fix(mobile): the page for adding photos to the album cannot be navigated back using gestures #16449
Conversation
df04152
to
cd89e5c
Compare
@ExceptionsOccur Thanks a lot for the fix. Can you rebase the branch over main and remove the changes in other files. The fix is only in the file |
…ted back using gestures immich-app#16409
cd89e5c
to
3667156
Compare
Alright, the code for the other part will be submitted in a new PR. |
A small remark though, your change makes the back gesture deselect all assets and immediately close the selection page. However, it is a much better experience if the first gesture deselects the assets and the next one goes back. The actual change to handle this is rather simple, you just need to find the difference between the selectedAssets and the preselectedAssets and prevent pop when the difference is empty |
Indeed, it can be done this way. I will optimize it later. Mainly, I remember that before it was returned directly, so when I fixed it, I also did it according to the previous idea. |
if (didPop) { | ||
return; | ||
} else { | ||
if (_selectedAssets.length != widget.preselectedAssets!.length && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't always assume the widget.preselectedAssets
value will be available and should handle it being null more gracefully.
fix(mobile): the page for adding photos to the album cannot be navigated back using gestures #16449