feat(mobile): Auto switching server URLs #14437
Conversation
alextran1502
requested review from
shenlong-tanwen,
fyfrey,
zackpollard and
mertalev
mobile/lib/widgets/settings/networking_settings/external_network_preference.dart
Outdated
Show resolved
Hide resolved
mobile/lib/widgets/settings/networking_settings/external_network_preference.dart
Outdated
Show resolved
Hide resolved
mobile/lib/widgets/settings/networking_settings/external_network_preference.dart
Outdated
Show resolved
Hide resolved
mobile/lib/widgets/settings/networking_settings/networking_settings.dart
Outdated
Show resolved
Hide resolved
mobile/lib/widgets/settings/networking_settings/networking_settings.dart
Outdated
Show resolved
Hide resolved
mobile/lib/widgets/settings/networking_settings/local_network_preference.dart
Show resolved
Hide resolved
mobile/lib/widgets/settings/networking_settings/endpoint_input.dart
Outdated
Show resolved
Hide resolved
mobile/lib/widgets/settings/networking_settings/endpoint_input.dart
Outdated
Show resolved
Hide resolved
mobile/lib/widgets/settings/networking_settings/local_network_preference.dart
Outdated
Show resolved
Hide resolved
mobile/lib/widgets/settings/networking_settings/local_network_preference.dart
Outdated
Show resolved
Hide resolved
|
I really like the settings makeover. Have you checked that all the connection/wifi settings work in the background backup? |
| final entries = | ||
| useState([AuxilaryEndpoint(url: '', status: AuxCheckStatus.unknown)]); | ||
| final canSave = | ||
| useState(entries.value.every((e) => e.status == AuxCheckStatus.valid)); |
mobile/lib/widgets/settings/networking_settings/networking_settings.dart
Outdated
Show resolved
Hide resolved
mobile/lib/widgets/settings/networking_settings/networking_settings.dart
Outdated
Show resolved
Hide resolved
|
Alright @mertalev resolved the comments and also removed the blur. Please give it another spin |
alextran1502
changed the title
| @@ -8,36 +8,69 @@ import 'package:immich_mobile/widgets/settings/asset_list_settings/asset_list_se | |||
| import 'package:immich_mobile/widgets/settings/asset_viewer_settings/asset_viewer_settings.dart'; | |||
| import 'package:immich_mobile/widgets/settings/backup_settings/backup_settings.dart'; | |||
| import 'package:immich_mobile/widgets/settings/language_settings.dart'; | |||
| import 'package:immich_mobile/widgets/settings/networking_settings/networking_settings.dart'; | |||
| import 'package:immich_mobile/widgets/settings/notification_setting.dart'; | |||
| import 'package:immich_mobile/widgets/settings/preference_settings/preference_setting.dart'; | |||
| import 'package:immich_mobile/routing/router.dart'; | |||
|
|
|||
| enum SettingSection { | |||
There was a problem hiding this comment.
I was initially thinking about shortening the subtitles, but now I'm looking at it more closely and the subtitles are all just restating the title. There's no new info. The sections are all self-explanatory, so I think you can just get rid of the subtitles. It'll look cleaner and allow it to be more compact.
There was a problem hiding this comment.
Also, some of the entries are thicker than others because the subtitle is two lines vs. one, so removing them will make the thickness consistent.
There was a problem hiding this comment.
It doesn't look good without subtitles. I like having subtitles in this UI element as a design preference
There was a problem hiding this comment.
That's okay then. I think it'd still be better to bring the two-line subtitles down to one line, but I don't think this is blocking
mobile/lib/widgets/settings/networking_settings/networking_settings.dart
Outdated
Show resolved
Hide resolved
|
This is fantastic! Also, I noticed that when I open the Networking tab in the app, the scroll FPS drops to around 30. Could you explain why this happens? Thank you for your hard work! |
This PR adds Network Settings, which allow users to specify additional endpoints for automatic endpoint switching when on and off the local network.
When enabling the feature, the user can manually specify the WiFi name and target endpoint or auto-populate the current connection information for
Local Connection. As forExternal Connection, the user can specify a list of endpoints, ordered by priority. Those endpoints will be checked and verified, and the mobile app will establish the connection under the applicable network conditions.The app will need the Location Permission to get the WiFi name to work correctly.
This PR also redesigned the settings page.
Setting Pages
Network Settings
TODO