feat: transcode in stats #14418
feat: transcode in stats #14418
Conversation
| @@ -117,6 +117,10 @@ export class UserRepository implements IUserRepository { | |||
| 'usageVideos', | |||
| ) | |||
| .addSelect('users.quotaSizeInBytes', 'quotaSizeInBytes') | |||
| .addSelect( | |||
| `ARRAY_AGG(assets.encodedVideoPath) FILTER (WHERE assets.encodedVideoPath IS NOT NULL)`, | |||
There was a problem hiding this comment.
I feel like this is gonna be veeeery slow
| vi.mock('fs', async () => { | ||
| const actual = (await vi.importActual<typeof fs>('fs'))!; | ||
| return { | ||
| ...actual, | ||
| statSync: vi.fn().mockReturnValue({ size: 500 }), | ||
| }; | ||
| }); |
There was a problem hiding this comment.
This is now how you should be doing that. You should be mocking repo methods if you have to
| } | ||
|
|
||
| try { | ||
| const stats = fs.statSync(path); |
There was a problem hiding this comment.
Pretty sure we already have a repo method for that. If we don't, we should add one
There was a problem hiding this comment.
I'm not fully convinced we need this. There is an elegance to only counting the original files - it aligns with how cloud solutions count usage, is independent from the particular settings of the admin and the immich release, and leads to a more intuitive quota for the user. This PR only changes the visible stats, but this is also confusing since there's a discrepancy between what is actually included in the quota and what is displayed.
Even if we come to an agreement there, the particular approach in this PR is too bolted-on and would need to be designed in a better way that doesn't require scanning the file system and encompasses other generated files like thumbnails.
| } | ||
|
|
||
| try { | ||
| const stats = fs.statSync(path); |
There was a problem hiding this comment.
This is terribly slow and will scale poorly as the number of videos increases, both in fetching every single path from the DB at once and in stat'ing them like this.
I agree as regards the user's expectation. My change is only for the admin panel (at least that's how I intended it).
I agree, and now don't know why I did it this way to begin with. I think I didn't see the transcoded filesize in the db schema and wanted something that just worked now. I guess a more reasonable solution is to have the transcoding job update the asset table with the new file's size so it can be queried directly.
Happy to include other things like thumbnails, database, and immich code itself tbh. I'd like the admin panel to just show everything immich is using. Transcoding just seemed like the biggest chunk. |
|
You're right - the file size for transcodes etc. isn't stored anywhere. I think it'd be reasonable to add a file size column in the The only limitation of this is that it won't retroactively count files generated before this change, but I think this is okay as long as it's noted somewhere. |
Adds transcoded videos storage usage to the server stats page, both for users and server total.
Mentioned in #14093.