Skip to content

allow multiple tax statements#111

Open
caifara wants to merge 1 commit intoimmateriel:masterfrom
caifara:taxes
Open

allow multiple tax statements#111
caifara wants to merge 1 commit intoimmateriel:masterfrom
caifara:taxes

Conversation

@caifara
Copy link
Copy Markdown

@caifara caifara commented Mar 23, 2023

We came across onix messages with multiple tax statements. This PR changes the price.tax call into price.taxes to support such cases.

@julbouln
Copy link
Copy Markdown
Member

Hi,

Thank you for your contribution !

To avoid API break, it would be nice to add a singular tax method like for place https://github.com/immateriel/im_onix/blob/master/lib/onix/contributor.rb#L49

@caifara
Copy link
Copy Markdown
Author

caifara commented Mar 23, 2023

Hi, thanks for your quick response!

I wrote one but removed it later because it may create the impression there is just one tax statement. Multiple tax statements in our case are used when the price amount is split between multiple tax rates. So reading only one results in wrong information.

Would you be okay with a singular tax method that raises when multiple are available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants