Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Drop usage of lodash, use simple helper for first, fix #22 #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Drop usage of lodash, use simple helper for first, fix #22 #23

wants to merge 1 commit into from
+7 −3

Conversation

ovr
Copy link

@ovr ovr commented May 21, 2021 •
edited
Loading

Hello!

refs cube-js/cube#2799
refs #22

  • I copy/paste first method from lodash, because it's one-liner
  • I drop usage of lodash (It was used only for first method)

Thanks

@igorlukanin
Copy link

Hi @ovr 👋 I wonder if this comment here is something worth looking at: #20 (comment)

@ovr
Copy link
Author

ovr commented Mar 15, 2022

ping @imjuni

2 similar comments
@ovr
Copy link
Author

ovr commented Mar 18, 2024

ping @imjuni

@ovr
Copy link
Author

ovr commented Mar 18, 2024

ping @imjuni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hassankhan hassankhan hassankhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ovr @igorlukanin @hassankhan