Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Grey-value co-occurrence matrices should be symmetric #632

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

haesleinhuepf
Copy link
Member

@haesleinhuepf haesleinhuepf commented Aug 11, 2020

Hi all,

as discussed with a user and @imagejan on the forum we assume that the grey level co-occurrence matrices should be symmetric. Otherwise, the direction of the read-out would play a role in further post-processing of the matrix.

Maybe @dietzc has an opinion here.

Thanks!

Cheers,
Robert

Otherwise, the direction of the read-out would play a role in further processing
@imagejan
Copy link
Member

I think we might want to have both a non-symmetric and a symmetric version of the co-occurrence matrix op. It seems for texture feature calculations really the non-symmetric matrix is used (although I find it surprising, because that means that mirroring an image results in different texture features...).

For reference, here's how it's done in scikit-image (where they default to symmetric=False and normed=False):

https://github.com/scikit-image/scikit-image/blob/2bf1a351a0c2e19fcd37168460a18954d4aabdd7/skimage/feature/texture.py#L15-L105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants