ci: run benchmark workflow on push to main for binding changes - #3296
Open
saurabhhhcodes wants to merge 1 commit into
Open
ci: run benchmark workflow on push to main for binding changes#3296saurabhhhcodes wants to merge 1 commit into
saurabhhhcodes wants to merge 1 commit into
Conversation
Closes im-anishraj#1898 bindings/** is already in the pull_request path filters (landed in 555c9ec, Jul 22). The remaining gap from im-anishraj#1898: binding changes merged to main still skip the benchmark workflow until a manual or scheduled run, so post-merge performance regressions from the Python/native bridge go unnoticed. - Add a push trigger on main filtered to the same paths (arnio, bindings, cpp, benchmarks, workflow file). - Keep pull_request triggers, jobs, and commands unchanged.
|
Someone is attempting to deploy a commit to the xtylishanish-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1898
Context
bindings/**is already present in thepull_request.pathsfilters (landed in 555c9ec, Jul 22), so the literal first step of the issue is satisfied on main. The remaining gap from the issue's 'Why it matters' is that binding changes merged tomainstill skip the benchmark workflow entirely — performance regressions or benchmark breakage from the Python/native bridge (bindings/bind_arnio.cpp) go unnoticed until a later scheduled/manual run.Change
pushtrigger onmain, filtered to the same paths as the pull_request trigger (arnio/**,bindings/**,cpp/**,benchmarks/**, the workflow file itself).pull_requesttriggers, benchmark jobs, and commands unchanged.Validation
git diff --checkcleanVerification