Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atge: register L1C reset funtction in atge_l1c_mii_ops table #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cgrzemba
Copy link
Contributor

@cgrzemba cgrzemba commented Jul 7, 2021

On NIC's with Atheros AR8151 v2.0 the atge driver has a problem if you disconnect the network cable on a running interface.
The error message reads as follows:

May 23 16:14:56 notebookcg2 atge: [ID 451854 kern.warning] WARNING: atge0: L1C chip detected a fatal error, interrupt status: 200
May 23 16:14:56 notebookcg2 atge: [ID 451854 kern.warning] WARNING: atge0: DMA read error
May 23 16:14:56 notebookcg2 atge: [ID 451854 kern.warning] WARNING: atge0: atge_device_stop() stopping TX/RX MAC timeout

After this error the interface will not work anymore until you remove the interface and reconfigure it again.

With this fix the interface will be reset on link down and will work as intended on link up.

I altered the atge_l1c_mii_reset function and used freebsd driver alc as guidance.

Copy link
Member

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to mail the illumos developers list. We don't do direct PRs. This PR, however, is a good place to POINT the list so they can review it.

Also, apart from fixing your problem, you may need some folks to confirm THEIR atge devices are still working (I suspect they will, but to integrate you need to generate tests.).

See here for the process: https://illumos.org/docs/contributing/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants