-
Notifications
You must be signed in to change notification settings - Fork 1
Add Calico Goldmane flow collector support to Operator #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
60c043c
83af51f
56b42eb
8a40bd5
c380317
a1f5ae8
89fbb5f
a943813
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| # Variables | ||
| APP_NAME := operator | ||
| DOCKER_USERNAME := aaronnguyenillumio | ||
| DOCKER_USERNAME := pki619 | ||
| DOCKER_IMAGE := $(DOCKER_USERNAME)/$(APP_NAME) | ||
| LOCAL_REGISTRY := localhost:5000 | ||
| LOCAL_IMAGE := $(LOCAL_REGISTRY)/$(APP_NAME) | ||
|
|
@@ -34,13 +34,13 @@ clean: | |
| .PHONY: docker-build | ||
| docker-build: | ||
| @echo "Building Docker image..." | ||
| docker buildx build --platform linux/amd64,linux/arm64 --load -t $(DOCKER_IMAGE):latest . | ||
| docker buildx build --platform linux/amd64,linux/arm64 --load -t $(DOCKER_IMAGE):calicof . | ||
|
||
|
|
||
| # Push Docker image to Docker Hub | ||
| .PHONY: docker-push | ||
| docker-push: | ||
| @echo "Pushing Docker image to Docker Hub..." | ||
| docker push $(DOCKER_IMAGE):latest | ||
| docker push $(DOCKER_IMAGE):calicof | ||
|
||
|
|
||
| # Deploy target (build and push Docker image to Docker Hub) | ||
| .PHONY: deploy | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The DOCKER_USERNAME has been changed from 'aaronnguyenillumio' to 'pki619'. This appears to be a personal username change that should not be committed to the repository. This should either be reverted or configured through an environment variable to avoid hardcoding personal usernames in the Makefile.