Skip to content
Open
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Variables
APP_NAME := operator
DOCKER_USERNAME := aaronnguyenillumio
DOCKER_USERNAME := pki619
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DOCKER_USERNAME has been changed from 'aaronnguyenillumio' to 'pki619'. This appears to be a personal username change that should not be committed to the repository. This should either be reverted or configured through an environment variable to avoid hardcoding personal usernames in the Makefile.

Suggested change
DOCKER_USERNAME := pki619
# DOCKER_USERNAME is expected to be provided via the environment,
# for example: export DOCKER_USERNAME=your-dockerhub-username

Copilot uses AI. Check for mistakes.
DOCKER_IMAGE := $(DOCKER_USERNAME)/$(APP_NAME)
LOCAL_REGISTRY := localhost:5000
LOCAL_IMAGE := $(LOCAL_REGISTRY)/$(APP_NAME)
Expand Down Expand Up @@ -34,13 +34,13 @@ clean:
.PHONY: docker-build
docker-build:
@echo "Building Docker image..."
docker buildx build --platform linux/amd64,linux/arm64 --load -t $(DOCKER_IMAGE):latest .
docker buildx build --platform linux/amd64,linux/arm64 --load -t $(DOCKER_IMAGE):calicof .
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Docker image tag has been changed from 'latest' to 'calicof', which appears to be a development or testing tag. This should not be committed to the main branch as it changes the default image tag for all users. Consider reverting this to 'latest' or using a proper versioning scheme.

Copilot uses AI. Check for mistakes.

# Push Docker image to Docker Hub
.PHONY: docker-push
docker-push:
@echo "Pushing Docker image to Docker Hub..."
docker push $(DOCKER_IMAGE):latest
docker push $(DOCKER_IMAGE):calicof
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Docker image tag has been changed from 'latest' to 'calicof', which appears to be a development or testing tag. This should not be committed to the main branch as it changes the default image tag for all users. Consider reverting this to 'latest' or using a proper versioning scheme.

Copilot uses AI. Check for mistakes.

# Deploy target (build and push Docker image to Docker Hub)
.PHONY: deploy
Expand Down
4 changes: 4 additions & 0 deletions api/generate.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,7 @@ package internal
//go:generate buf format -w illumio/cloud/k8sclustersync/v1/k8s_info.proto
//go:generate buf lint illumio/cloud/k8sclustersync/v1/k8s_info.proto
//go:generate buf generate illumio/cloud/k8sclustersync/v1/k8s_info.proto

//go:generate buf format -w illumio/cloud/goldmane/v1/goldmane.proto
//go:generate buf lint illumio/cloud/goldmane/v1/goldmane.proto
//go:generate buf generate illumio/cloud/goldmane/v1/goldmane.proto
Loading
Loading