Fix #159: Recently cleaned must reflect what Clean actually freed - #169
Merged
Merged
Conversation
Borisserz
force-pushed
the
fix/smartscan-recently-cleaned
branch
from
September 16, 2026 16:54
261edce to
aea10ac
Compare
iliyami
force-pushed
the
fix/smartscan-recently-cleaned
branch
from
September 17, 2026 08:14
aea10ac to
6c551be
Compare
Owner
|
Verified safe (reporting-only; delete calls byte-identical, removedURLs recorded only on success). Rebased over the thinning-cancel (#170) and Excluded-Folders (#142) changes; resolved the CleanActions overlap so the cancel-after-permanent path also threads removedURLs. Full suite green at 862. Merging. Thanks @Borisserz! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
swift test --filter 'SmartScanCleanupTests|CleaningEngineTests'— 21 passed\n-swift test— 808 executed, 3 skipped;ModuleE2ETests.testDuplicates_groupsByteIdenticalFilesstill fails two unrelated duplicate-scanner assertions and reproduces in isolation\n\nCloses Smart Scan Recently cleaned lists items that were never freed #159