Fix #154: reject short/generic AppMatching leftover patterns - #167
Merged
Merged
Conversation
Borisserz
force-pushed
the
fix/appmatching-short-patterns
branch
from
September 16, 2026 16:46
bfd4c22 to
2b77e5b
Compare
Owner
|
Verified safe: strictly subtractive (count >= 3 and not 'app'), closes the short/generic leftover over-match without widening matching or touching deletion; composes with the earlier empty-pattern filter. Merging. Thanks @Borisserz! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apptoken before filename substring matchingX/Firefox andApp 2.0.1/WhatsApp while preserving normal matchesTests
swift test --filter AppMatchingTests(25 tests, 0 failures)Closes #154