Disable New Program Year save button if no available academic years#9367
Open
michaelchadwick wants to merge 2 commits into
Open
Disable New Program Year save button if no available academic years#9367michaelchadwick wants to merge 2 commits into
michaelchadwick wants to merge 2 commits into
Conversation
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
What an excellent catch @michaelchadwick |
dartajax
approved these changes
Jun 3, 2026
Member
dartajax
left a comment
dartajax
left a comment
There was a problem hiding this comment.
click tested - looks fine to me
stopfstedt
requested changes
Jun 3, 2026
Member
stopfstedt
left a comment
stopfstedt
left a comment
There was a problem hiding this comment.
the fix works as intended. code looks good. the styles can be streamlined, please see line comments.
| <button | ||
| type="button" | ||
| class="done text" | ||
| class="done text{{if this.noAvailableYears ' disabled'}}" |
Member
There was a problem hiding this comment.
the added class is not necessary if you use the :disabled pseudo class in the stylesheet instead.
| .buttons { | ||
| @include m.ilios-form-buttons; | ||
|
|
||
| button.disabled { |
Member
There was a problem hiding this comment.
use the :disabled pseudo class instead.
Suggested change
| button.disabled { | |
| button:disabled { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ilios/ilios#7168