Publication Review Buttons and Checkboxes now using Radio Button Groups#9357
Open
michaelchadwick wants to merge 6 commits into
Open
Publication Review Buttons and Checkboxes now using Radio Button Groups#9357michaelchadwick wants to merge 6 commits into
michaelchadwick wants to merge 6 commits into
Conversation
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
❌ Visual Diff Report — FAILED884 images compared: 41 different · 843 identical DetailsDifferences (41)
Download the results. |
michaelchadwick
changed the title
michaelchadwick
force-pushed
the
frontend-6854-pub-review-make-radio-buttons
branch
from
7ea27fb to
222e5e9
Compare
…boxes; bulk radio selection also gets unchecked if non-default action is selected
…he bulk action radio button group reflects this
michaelchadwick
force-pushed
the
frontend-6854-pub-review-make-radio-buttons
branch
from
222e5e9 to
ac3689f
Compare
stopfstedt
requested changes
Jun 4, 2026
|
|
||
| get sessionsToAllBePublished() { | ||
| if (this.sessionsToPublish?.length) { | ||
| return !this.sessionsToSchedule?.length ? true : false; |
Member
There was a problem hiding this comment.
Suggested change
| return !this.sessionsToSchedule?.length ? true : false; | |
| return !this.sessionsToSchedule?.length; |
Contributor
Author
There was a problem hiding this comment.
In fact, this could be simplified even further?
get sessionsToAllBePublished() {
return !this.sessionsToSchedule?.length;
}
|
|
||
| get sessionsToAllBeScheduled() { | ||
| if (this.sessionsToSchedule?.length) { | ||
| return !this.sessionsToPublish?.length ? true : false; |
Member
There was a problem hiding this comment.
Suggested change
| return !this.sessionsToPublish?.length ? true : false; | |
| return !this.sessionsToSchedule?.length; |
Contributor
Author
There was a problem hiding this comment.
In fact, this could be simplified even further?
get sessionsToAllBeScheduled() {
return !this.sessionsToPublish?.length;
}
stopfstedt
approved these changes
Jun 4, 2026
dartajax
approved these changes
Jun 4, 2026
Member
dartajax
left a comment
dartajax
left a comment
There was a problem hiding this comment.
looks good to me - I like this - much improved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ilios/ilios#6854
This changes the "Publish All As-Is" and "Mark All As Scheduled" bulk action buttons for Publication Review into a semantically clearer radio button group. It also changes individual session row checkboxes into radio button groups.