Conversation
thodkatz
force-pushed
the
ci-multiple-os
branch
from
660831b to
140173c
Compare
thodkatz
force-pushed
the
ci-multiple-os
branch
27 times, most recently
from
ceb85a6 to
8f2fbc4
Compare
thodkatz
force-pushed
the
ci-multiple-os
branch
11 times, most recently
from
969cc47 to
85feeac
Compare
Collaborator
Author
|
I think finally it is good to go. The macos and windows workflows fail due to the pickle issue mentioned and resolved here #212. We can either merge the #212 and after this or the reverse :P I have spoted and resolved another issue (54b4c96) similar to the #218, where if a test fails the process isn't closed. I have deleted the circlie ci config as well, we can unlink the repo with the circle ci... |
thodkatz
force-pushed
the
ci-multiple-os
branch
2 times, most recently
from
34544e2 to
b2672a4
Compare
thodkatz
force-pushed
the
ci-multiple-os
branch
from
b2672a4 to
dca525f
Compare
thodkatz
force-pushed
the
ci-multiple-os
branch
4 times, most recently
from
37d7a22 to
9a75415
Compare
thodkatz
force-pushed
the
ci-multiple-os
branch
from
9a75415 to
8f4fa85
Compare
Collaborator
Author
|
Okey, I think I have addressed the comments, and the ci is failing only for the pickle issue :) Let me know @k-dominik, and thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.