Resolved #1,#2,#3,#4,#7,#8,#10 #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing sure that string data is handled correctly.
- [x] Added Memory keyword for string datatype - [x] Memory usage Optimization - [x] Made function payable and transferred nft after successful transfer of funds to the user - [x] remove unnecessary code and optimized the function for seller - [x] added visiblity keyword external for ERC721 interface - [x] Completed the deployment script of Contract.sol
vishal18713
changed the title
akhilender-bongirwar
requested review from
akhilender-bongirwar and
TechWizard9999
There was a problem hiding this comment.
This isn't the correct approach for managing PRs. It's essential to create separate branches for each issue, resolve them within their respective branches, and then submit a PR based on those branches. For further guidance, please refer to these rules, and then proceed accordingly.
There was a problem hiding this comment.
@TechWizard9999 please update the contributing section in Readme.md to avoid such PR's
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1 => As string cannot be directly stored inside the temporary memory of blockchain(unlike uint), it needs to be specified with the memory keyword .
#2 => The memory keyword cannot be used inside a struct declaration as that structs are meant to define the layout of data in storage or as part of the contract's state. Unlike function parameters or local variables, which are temporary and stored in memory, struct members are stored in the contract's storage or are part of the contract's state. Therefore, specifying memory for struct members would be contradictory, as structs are intended to define data storage layout, not temporary data.
#3 => To make a function ready for transaction it must be mentioned as payable . For it's enhancement , the require tag is used so as to check whether the transfer to seller is successful or not then the transfer of the NFT( referring to that property) is done and finally the property token is removed from the property sale list.
#7 => Firstly, the right to cancel the Sale is given only to the seller .Then the NFT for the property is checked (whether or not it is available for the sale) . If the seller wants to cancel the sale of that property then the NFT of that particular property is deprecated from the list and then finally removed the unnecessary line of code.
#8 => For importing of the interface into other contracts it must be mentioned as external .
#10 => Completed the script for deployment of the second smartcontract "Contract.sol"
#4 => Deployed contracts on three different networks
Sepolia Network
Contract Address:-
Real Estate: 0xcAbd71D2357968599ed722C0E934008A9f65D88F
Contract: 0x933b09e7EDb3aDB32bC3dEFffCf89DE2aFf5aa68
Polygon Mumbai
Contract Address:-
Real Estate: 0x56F87BAC8340D2721C37c07B4b897017ddfAb361
Contract: 0xE0CC81dF93F7617d5da3C90A0808eC42a26497D3
Arbitrum
Contract Address:-
Real Estate: 0x56F87BAC8340D2721C37c07B4b897017ddfAb361
Contract: 0xE0CC81dF93F7617d5da3C90A0808eC42a26497D3