Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2 Added weather Script #32

Closed
wants to merge 4 commits into from

Conversation

aryamagarwal
Copy link

@aryamagarwal aryamagarwal commented Mar 15, 2024

Fixes #2
I have written a bash script to read the location given by the user and convert that into required format before fetching result from wttr.in.

weather

@aryamagarwal aryamagarwal changed the title Added weather Script. Solving issue #2 #2 Added weather Script Mar 15, 2024
@rootCircle
Copy link
Member

Hi @aryamagarwal, your implementation is non shell compatible, and hence will simply not work in other shells like zsh etc. Try working on that! zsh scripts/weather

Also it would be better if that curl load text is not visible to user for nicer ux.

ping me here when you're done with those, so we can move forward with your PR!

@aryamagarwal
Copy link
Author

@rootCircle I have removed curl load text using curl -s and improved the overall script using shellcheck. Kindly review it.

@rootCircle
Copy link
Member

LGTM 👍 Please move the file to scripts/ directory! Ping when when it's done!

@aryamagarwal
Copy link
Author

@rootCircle I have made the changes. Kindly review it.

@aryamagarwal
Copy link
Author

@rootCircle I have shifted weather script in scripts folder.

@ecxtacy
Copy link

ecxtacy commented Mar 17, 2024

Looks good. Nice work.

@ecxtacy ecxtacy closed this Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write weather script.
3 participants