#6 Added perms script #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kindly put proper PR heading. |
|
Updated the PR heading. |
rootCircle
requested changes
Mar 15, 2024
|
Please make the required changes! You can use linter like |
|
ping me here when you're done with those, so we can move forward with your PR! |
rootCircle
approved these changes
Mar 16, 2024
|
Hey @aryamagarwal! Great work on fixing those issues, I am seeing that your code simply fails to work for directory! Can you check into that?
ping me here when you're done with those/need any help, so we can move forward with your PR! |
|
LGTM 👍 Accepted! Great work @aryamagarwal! Thanks for your contribution! also keep a good practice to write only relevant names for branches! like feat-perms fix-#6 etc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6
I've written a Bash script to list the permissions of given files in octal format.
The script loops through each file to retrieve its permissions using the ls command and outputs the permissions in the specified format.