Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more colors in the color script #9 #20

Closed
wants to merge 3 commits into from

Conversation

Priyanshu-2005
Copy link

@Priyanshu-2005 Priyanshu-2005 commented Mar 14, 2024

Fixes #9

Added more colors.

When we will run the script in terminal the output will be like as shown in following images:

Command used:
bash color <color_name> && echo "hello"

Screenshot from 2024-03-15 01-52-40

Command used:
bash color reset

Screenshot from 2024-03-15 02-10-14

@ecxtacy
Copy link

ecxtacy commented Mar 15, 2024

@Priyanshu-2005 thanks for contributing here. I have not manually tested it yet, but you can do the following improvements in PR description.

  1. Write Fixes #issue-number in the PR description, not just issue #issue-number

  2. Use proper capitalisation and punctuation.

  3. Use the backtick (`) when mentioning code lines. like this Proper formatting is a must for a great PR.

@Priyanshu-2005
Copy link
Author

Priyanshu-2005 commented Mar 15, 2024

@ecxtacy I have edited the description acccording to the suggestions.
I will definitely follow them for other PRs too.

@rootCircle
Copy link
Member

Great work @Priyanshu-2005! Can you handle checks for when no args is passed as well? Currently it errors out

image

@rootCircle
Copy link
Member

ping me here when you're done with those, so we can move forward with your PR!

@Priyanshu-2005
Copy link
Author

Priyanshu-2005 commented Mar 15, 2024

@rootCircle Now the code script would be able to handle the error we that were getting on passing no arguments.

Commands Used:
bash color
bash color magenta && echo hello
image

@rootCircle
Copy link
Member

LGTM 👍 Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding more colors in the color script
3 participants