Conversation
4 tasks
Collaborator
Author
|
Wrote an ad-hoc fix. @phackstock if you need this soon, would you perhaps be able to take this a bit further (i.e. maybe a tests/docs, and check if my implementation makes sense)? @znicholls FYI |
Collaborator
Thanks, I put my comments in the issue to keep things in one place, implementation looks fine and I think adding tests/docs would be great (there's probably a much larger conversation to be had about whether we want to put more effort into cleaning things up in the repo in general, let me know if you have thoughts on that too). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For full description of error, see #19.
CHANGELOG.rstadded (single line such as:(`#XX <https://github.com/iiasa/climate-assessment/pull/XX>`_) Added feature which does something)