Handled cases when no landmark in some of the frame in videos. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ac-alpha
reviewed
Feb 24, 2025
| @@ -73,14 +73,16 @@ def list_reqs(fname='requirements_new.txt'): | |||
| include_package_data=True, | |||
| license=license, | |||
| entry_points={ | |||
| 'console_scripts': 'libreface=libreface.commandline:main_func' | |||
| 'console_scripts': [ | |||
There was a problem hiding this comment.
Why did you change this to a list? Was it not working without the [] list?
There was a problem hiding this comment.
I think this change was made during the previous issues with testpypi,
Now after addressing the issue I believe changing this to a list won't have any difference with the previous version,
but at least it passes all the tests after this change so I just remain it there as it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libreface will be able to handle input videos, in which only partial of the frames of the video has detectable landmarks. This should address issue11,
Notice: the command line tool of libreface may not be fixed yet in this commit