Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assertion for a maximum spell points #9556

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Fix assertion for a maximum spell points #9556

merged 2 commits into from
Feb 12, 2025

Conversation

ihhub
Copy link
Owner

@ihhub ihhub commented Feb 11, 2025

close #9544

@ihhub ihhub added logic Things related to game logic crash Application crashes. The highest level of priority labels Feb 11, 2025
@ihhub ihhub added this to the 1.1.6 milestone Feb 11, 2025
@ihhub ihhub self-assigned this Feb 11, 2025
@ihhub ihhub requested a review from Branikolog February 11, 2025 14:13
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Branikolog
Branikolog approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@Branikolog Branikolog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @ihhub

The assertion does not occur anymore! 👍

@Branikolog
Copy link
Collaborator

However,, after I accept some value below 999, next time I want to edit spell points I can't exceed 999, until I reset point to max (1000+).

@ihhub ihhub merged commit d4e4502 into master Feb 12, 2025
23 checks passed
@ihhub ihhub deleted the max-spell-points branch February 12, 2025 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Branikolog Branikolog Branikolog approved these changes

Assignees

@ihhub ihhub

Labels
crash Application crashes. The highest level of priority logic Things related to game logic
Projects
None yet
Milestone
1.1.6
Development

Successfully merging this pull request may close these issues.

Crash/assertion on trying to modify more than 999 mana points available
2 participants
@ihhub @Branikolog