🛤️ Migrate to the Compose Multiplatform Navigation #779
+935
−588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorescodro
force-pushed
the
update/navigation
branch
3 times, most recently
from
f2fa0d4 to
adafe7d
Compare
igorescodro
force-pushed
the
update/navigation
branch
from
9d28543 to
7c38a99
Compare
A new Compose Navigation dependency was added once Voyager doesn't seem to be maintained anymore.
New destinations and events were created to represent all the app's screens and how to interact between them.
Initial structure connecting the AndroidX Navigation with our custom implementation created.
All the existing destinations were migrated from Voyager to the new navigation system. Future commits will handle the deep links and port more destinations (such as confirmation dialogs) to this system.
Bye, bye, my friend!
Name updated
New mandatory tag added after updating Compose
Since Compose Multiplatform does not fully support deep links, the initial implementation was created, and it will be updated when the support is ready. For now, every deep link will simply open Alkaa's main screen.
A new module and a Wrapper to provide the `PermissionsController` instance. This class holds a single instance of `PermissionsController` since Moko does not allow `BindEffect` to be called outside an Activity context (Alkaa uses in a `dialog` destination).
The behavior for keep the tab state after rotating the screen was re-introduced. Small changes were needed to ensure the data can be properly stored in the `Bundle`.
After the recent updates, the `rememberSaveable` for the `LocalDateTime` was not working properly. For now, the value will be stored as a `Long` and converted to DateTime as needed.
Adding ModalBottomSheet implementations to show the content in a BottomSheet for the Category Edit/Add and Task Add.
Additional functions called to improve the navigation. The improvements are: - Avoid navigating to the same place if it's already on top - Save and restore state for the TopLevel destinations
igorescodro
force-pushed
the
update/navigation
branch
from
7c38a99 to
e62d701
Compare
New module created to avoid circular dependencies. Ideally, the interfaces from `navigation` should be moved here. For now, it is what it is. 😀
igorescodro
force-pushed
the
update/navigation
branch
from
e62d701 to
4a7e7de
Compare
A new structure was created to emit the changes in the Top Level destinations and update the Bottom Navigation (or NavRail) and the Top App Bar. The solution is based on the official Navigation Compose documents and Now in Android project.
igorescodro
force-pushed
the
update/navigation
branch
from
4a7e7de to
6cb81e8
Compare
The build task is failing even though the app is working fine. Time to fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating to the new Compose Multiplatform Navigation library and implementing a new navigation system based on events.
Fix #661