Fixes #399: Upgrade to be compatible with Openfire 5.0.0 #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dependencies and release notes.
This plugin contains two Jersey deployment dependencies: - an HTTP server based one: jersey-container-jetty-http - a Servlet-based one: jersey-container-jetty-servlet I don't see why both are needed. As Jersey seems to be deployed as a servlet (this plugin contains a `web.xml` file that initiates `org.glassfish.jersey.servlet.ServletContainer`) the HTTP server based container dependency seems redundant. Removing the HTTP server based dependency also resolves an issue with the upgrade of Jetty from 10 to 12 (`java: cannot access org.eclipse.jetty.server.Deployable - class file for org.eclipse.jetty.server.Deployable not found`).
With Jetty 12, Openfire will require Java 17 or later.
guusdk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #339: Using Jetty 12's EE8 WebAppContext. Updated dependencies and release notes.