Repository navigation
feat(builtin-skills): add four daily-life planning skills - #1115
Open
mapleyebaby wants to merge 3 commits into
Open
mapleyebaby wants to merge 3 commits into
mapleyebaby wants to merge 3 commits into
Conversation
Signed-off-by: maple <mapleyebaby@gmail.com>
Signed-off-by: maple <mapleyebaby@gmail.com>
Signed-off-by: maple <mapleyebaby@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What changed? Four new reviewed builtin Skill packages, plus their catalog and eval entries. No backend, frontend, CLI, scanner, deployment or runtime-manifest change.
trip-planning-briefFallbackandVerify), budget range with buffer + known-miss list, constraint check[verify]; never infers health, age, mobility or dietpacking-checklistnumber + formula,Weightlimited tomust/nice/conditional, wear-on-the-day, regulated-items table, trim planevent-plannermeal-and-grocery-plannerEach package's linter is fail-closed: a missing table or column is a FAIL rather than a warning; empty
Fallback, placeholder owners (team,TBD), non-formula quantities, duplicate ingredients and forbidden claims (booking/paid/guaranteed/calorie/allergy-safe) all fail. Verified not to be "always green" — a deliberately broken sample produced 9 failures and exit 1.Why is this needed?
docs/22-builtin-skills-candidate-pool.md§7 identifies "Skills that need no account to be useful" — daily-life, travel and event planning — as the weakest part of the candidate pool, and asks SkillHub to maintain exactly these four small, well-scoped Skills. §108 rules out booking, emailing, auto-publishing and cloud writes for this batch. The earlier candidatetravel-planner(B25) was rejected (§60/§141) for failing generation and for persisting a profile to~/.claude/travel_planner/; these four are planning-only, never persist, and never infer personal attributes. None of the existing 24 packages covers trips, packing, events or meals.Provenance note
These four packages are original work, not forks.
catalog.jsonhas no way to express that today:upstream.commitis required andscripts/build-builtin-skills.pyenforces[0-9a-f]{40}.The entries therefore carry a 40-zero placeholder rather than an invented SHA — a real value here would read as a provenance claim that is not true, and a placeholder is at least honest about being one.
NOTICE.mdstates "Original work, first published in SkillHub" and carries the same placeholder. The build passes with the placeholder because it is a syntactically valid coordinate.This is the gap tracked in #1113. Once maintainers decide, the entries become either
origin: "original"(my preference, and what the issue proposes) or a pinned merge SHA — both are a one-line change per entry. I did not touchscripts/build-builtin-skills.py, since that validation belongs to maintainers.Validation
.trellis/spec/testing/index.md; exclusions explainedThe relevant check for this change set is
make test-builtin-skills, plus the deterministic build it wraps.Commands run:
Results observed locally:
artifacts.json..entries, and containsSKILL.md+LICENSE.txt+NOTICE.mdexamples/file: exit 0,0 warning(s)Documentation-only follow-up (updating
docs/22§7 coverage) is intentionally not in this PR to keep the diff reviewable — see Notes.Risk
docs/22§8 (CDN upload,manifest.jsoncoordinates, SHA-256) stay with maintainers, exactly as for any other builtin package.Notes
origin: "original"provenance mode so future original packages don't pin a meaningless SHA ([Feature] Let builtin-skills express "no upstream" so original packages don't need a fake commit #1113); (2) updatedocs/22-builtin-skills-candidate-pool.md§7 to mark these four as covered — I left it alone on purpose, since it is a business-policy statement andAGENTS.mdsays to report such conflicts rather than silently redefine them.docs/22wording would follow in the same PR if maintainers prefer that; say the word and I will add a docs-only commit.