Skip to content

feat(builtin-skills): add four daily-life planning skills - #1115

Open
mapleyebaby wants to merge 3 commits into
iflytek:mainfrom
mapleyebaby:feat/builtin-daily-life-skills
Open

mapleyebaby wants to merge 3 commits into
iflytek:mainfrom
mapleyebaby:feat/builtin-daily-life-skills

Conversation

@mapleyebaby

Copy link
Copy Markdown

Summary

What changed? Four new reviewed builtin Skill packages, plus their catalog and eval entries. No backend, frontend, CLI, scanner, deployment or runtime-manifest change.

builtin-skills/skills/trip-planning-brief/          SKILL.md, LICENSE.txt, NOTICE.md,
builtin-skills/skills/packing-checklist/            references/ (4), examples/ (1),
builtin-skills/skills/event-planner/                scripts/check-*.py (1)
builtin-skills/skills/meal-and-grocery-planner/
builtin-skills/catalog.json    +4 entries, kept sorted by slug
builtin-skills/evals.json      +4 cases, one per slug
Slug What it produces Hard boundary
trip-planning-brief Trip brief, fixed-column day plan (8 columns incl. Fallback and Verify), budget range with buffer + known-miss list, constraint check No booking, no payment, no calendar writes; opening hours / fares / closures must carry [verify]; never infers health, age, mobility or diet
packing-checklist Categorised list where every quantity is number + formula, Weight limited to must/nice/conditional, wear-on-the-day, regulated-items table, trim plan Never states current liquid/battery/knife/medication limits as fact — names the authority to ask; no brand, price or stock claims
event-planner Countdown timeline with one owner role per row + dependency + done-when, material quantities with a stated driver, budget range with contingency, run of show with irreversible moments, emergency sheet with cost caps Never claims invitations sent / venue booked / vendor confirmed; no invented fire-code, permit or insurance numbers
meal-and-grocery-planner Menu table with equipment and time, grocery list aggregated by store section (one line per ingredient), cost range, prep timeline, leftover plan, substitutions No calorie or macro targets, no medical claims, no assumed dietary/religious/allergy constraints, food-safety figures deferred to local authority

Each package's linter is fail-closed: a missing table or column is a FAIL rather than a warning; empty Fallback, placeholder owners (team, TBD), non-formula quantities, duplicate ingredients and forbidden claims (booking/paid/guaranteed/calorie/allergy-safe) all fail. Verified not to be "always green" — a deliberately broken sample produced 9 failures and exit 1.

Why is this needed? docs/22-builtin-skills-candidate-pool.md §7 identifies "Skills that need no account to be useful" — daily-life, travel and event planning — as the weakest part of the candidate pool, and asks SkillHub to maintain exactly these four small, well-scoped Skills. §108 rules out booking, emailing, auto-publishing and cloud writes for this batch. The earlier candidate travel-planner (B25) was rejected (§60/§141) for failing generation and for persisting a profile to ~/.claude/travel_planner/; these four are planning-only, never persist, and never infer personal attributes. None of the existing 24 packages covers trips, packing, events or meals.

Provenance note

These four packages are original work, not forks. catalog.json has no way to express that today: upstream.commit is required and scripts/build-builtin-skills.py enforces [0-9a-f]{40}.

The entries therefore carry a 40-zero placeholder rather than an invented SHA — a real value here would read as a provenance claim that is not true, and a placeholder is at least honest about being one. NOTICE.md states "Original work, first published in SkillHub" and carries the same placeholder. The build passes with the placeholder because it is a syntactically valid coordinate.

This is the gap tracked in #1113. Once maintainers decide, the entries become either origin: "original" (my preference, and what the issue proposes) or a pinned merge SHA — both are a one-line change per entry. I did not touch scripts/build-builtin-skills.py, since that validation belongs to maintainers.

Validation

  • Applicable checks selected from .trellis/spec/testing/index.md; exclusions explained
  • Backend tests passed when backend behavior changed — n/a, no backend change
  • Frontend typecheck/build passed when frontend files changed — n/a, no frontend change
  • OpenAPI SDK regenerated or checked when API contracts changed — n/a, no contract change
  • Smoke test run when relevant — n/a, no service surface touched

The relevant check for this change set is make test-builtin-skills, plus the deterministic build it wraps.

Commands run:

python3 scripts/build-builtin-skills.py
# Built 28 reviewed Skill packages in builtin-skills/dist

make test-builtin-skills   # CI; not runnable on my dev box (WSL bash without repo drive mounted)

Results observed locally:

  • two builds to separate output dirs produce byte-identical artifacts.json
  • 28 artifacts, ascending by slug; each new zip has sorted member names, no absolute or .. entries, and contains SKILL.md + LICENSE.txt + NOTICE.md
  • 28 package directories == 28 catalog slugs == 28 eval slugs; re-running the merge tool leaves both lists byte-identical
  • each package's linter on its own examples/ file: exit 0, 0 warning(s)
  • broken-sample negative test: exit 1, 9 failures

Documentation-only follow-up (updating docs/22 §7 coverage) is intentionally not in this PR to keep the diff reviewable — see Notes.

Risk

  • User-facing impact: four additional optional packages in the published set. Existing slugs, versions, SKILL.md compatibility and namespace/CLI contracts are untouched.
  • Deployment or migration impact: none. No schema, config, container or runtime-manifest change; the release steps in docs/22 §8 (CDN upload, manifest.json coordinates, SHA-256) stay with maintainers, exactly as for any other builtin package.
  • Rollback approach: revert the commits. Content is purely additive, so nothing else depends on it; the two list files return to their prior state because entries are appended in sorted order.

Notes

Signed-off-by: maple <mapleyebaby@gmail.com>
Signed-off-by: maple <mapleyebaby@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant