Skip to content

feat(dsh): connect accounts and manage namespace skills and members - #1114

Open
dongmucat wants to merge 7 commits into
mainfrom
feat/dsh-account-namespace
Open

dongmucat wants to merge 7 commits into
mainfrom
feat/dsh-account-namespace

Conversation

@dongmucat

Copy link
Copy Markdown
Collaborator

Summary

Connect the native DSH skill center to the configured SkillHub registry using a personal API token. The same plugin works with the hosted registry and self-hosted installations through existing HTTP endpoints.

  • Upload a ZIP to a namespace selected from current memberships, confirm visibility, and check the returned version status. Reuse the CLI publish endpoint and the registry’s own publication policy.
  • Browse team skills and personal uploads, install authorized packages, and delete an owned skill by its ID. View team rosters, search registered users, and manage members within the account’s existing role.
  • Expose explicit namespace grants in the token UI. Preserve the authority of existing tokens during upgrades. Keep credentials in the personal Host/profile and bind them to the configured source.

Verification

Includes tests for token scopes, the PostgreSQL migration, namespace membership and ownership, the shared upload contract, remote errors and credential separation. The relevant checks are the backend Maven suite, web build/lint/Vitest, DSH plugin check, and CLI build/typecheck/lint/tests.

…members

Signed-off-by: dongmucat <1127093059@qq.com>
@dongmucat
dongmucat force-pushed the feat/dsh-account-namespace branch from f02b1be to e6002ce Compare November 20, 2026 07:37
Signed-off-by: dongmucat <1127093059@qq.com>
Signed-off-by: dongmucat <1127093059@qq.com>
Signed-off-by: dongmucat <1127093059@qq.com>
@dongmucat

dongmucat commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator Author

Final commit 6a17569 passed the local verification commands.

  • Backend make test-backend completed with BUILD SUCCESS and zero failures or errors. The default suite reports 30 conditional integration cases skipped because their optional external archive fixture, S3 contract configuration or Redis Cluster configuration is absent.
  • Web lint and production build passed. All 1,969 Vitest tests passed.
  • CLI build, typecheck and lint passed. All 889 tests passed.
  • DSH build, typecheck and lint passed. All 840 tests passed.
  • Chromium UI smoke passed for login, the account menu, namespace navigation with browser history, member search/add, namespace and visibility selectors, upload receipt, and theme switching. This smoke uses a fixture registry.

The backend run includes actual PostgreSQL grant migrations, owned namespace queries and the real Go process integration tests. Production account verification requires deploying the corresponding server authorization changes.

GitHub checks on commit 6a17569 finished with 46 successes, zero failed or pending checks, and one conditionally skipped CodeQL job. This includes PostgreSQL 16/17, real-service E2E, Linux/macOS/Windows plugin checks and official DSH Host activation coverage.

Signed-off-by: dongmucat <1127093059@qq.com>
@dongmucat

Copy link
Copy Markdown
Collaborator Author

Fixed the four code-review findings in commit 332cda7.

  • Match the shared server manifest rules for lowercase skill.md, leading whitespace and an auxiliary references/SKILL.md. Root manifests take precedence, and ambiguous roots remain rejected.
  • Save credentials under the trusted Host Profile directory. Hosts without Profile context use process memory. Existing globally saved candidate credentials require a fresh sign-in.
  • Preserve AUTH_REQUIRED classification in catalog and favorites requests so identity, private queries and source context are cleared consistently.
  • Synchronize portaled dialog color schemes with the owning SkillHub view, including appearance changes while the dialog is open.

Validation passed locally: plugin build, typecheck, lint and 847 tests. Chromium regressions passed for normal login/member/upload workflows, an expired token during catalog search, and the upload dialog in dark mode. The account tests cover source separation, two Profiles under one home, independent logout and hosts without Profile context.

@dongmucat

dongmucat commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator Author

Second review fixes are in commit 8be3725.

  • A TARGET_CHANGED rejection occurs before upload POST. The dialog now refreshes the target, resets the inherited visibility and requires a new confirmation. Unknown writes remain blocked to prevent resubmission.
  • File and module queries retain AUTH_REQUIRED classification. Account cleanup also recognizes source revisions inside compound detail identities, covering expiry and logout without removing another source’s cached content.

Validation passed locally: build, typecheck, lint and all 849 plugin tests. New cache tests exercise actual QueryClient removal for direct and compound identities. Chromium regressions passed for expiry discovered in the Files tab, reconfirming a changed upload target, and blocking retries after an unknown write outcome.

Remote verification on 8be3725 is complete. All 46 executed checks passed, with zero failed or pending checks. The conditional CodeQL job was skipped. The first E2E attempt exited during backend startup before tests began. A rerun of that failed job passed with 188 tests passed and 3 skipped. No code changes were needed for the rerun. Linux, macOS and Windows Host activation checks all passed.

Signed-off-by: dongmucat <1127093059@qq.com>
@dongmucat

Copy link
Copy Markdown
Collaborator Author

CI monitoring is complete for b4f74bb.

All 46 executed checks passed, with zero failures and zero pending checks. The conditional CodeQL job was skipped. This includes real-service E2E, PostgreSQL 16/17 and Linux/macOS/Windows DSH Host activation checks.

The earlier E2E failure occurred during backend startup before tests began. A rerun passed. The target main branch advanced during monitoring and introduced one conflict in ApiTokenCapabilityCatalogTest. The merge preserves both repository-installation and namespace-account route assertions. Focused authentication tests and CLI checks passed locally, and all checks on the merge commit then passed remotely.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant