develop rebase - wallet std., dapp, test app #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronald-hood-jr
force-pushed
the
wallet-standard-proxy
branch
from
c9eefbf to
de73a54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This preliminary pull request contains the wallet standard interface for cryptid, the dapp that serves as the web user interface for DIDs, and a test app that can allow users to utilize the dapp through a preexisting wallet such as phantom by generating an iframe that is passed the relevant instructions and events.
Current questions/issues acting as blockers:
With my initial attempts at communicating with the locally hosted cryptid dapp through Iframe, I ran into the same issues when communicating between the proxy wallet and the base wallet as those that manifested with the extension implementation. How can these limitations of phantom registering only within the original browser be circumvented?
The actual registration of the proxy wallet with the example test app is also slightly troubling when it comes to the appropriate time to register since it must be after phantom has been recognized, but before the dapp loads.
The event handling between the proxy and base wallet that alerts whether a wallet has been connected, changedAccounts, transaction confirmations etc.
To add more context about the specific questions/issues, 1 and 2 pertains to where method invocations or instantiations go, and 3 is along the lines of how is this task best accomplished.