Updates, fixed build #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion to 0.3.7, attempted to fix Molevule Verift task
|
Thoughts? |
jnogol
reviewed
Aug 26, 2019
molecule/agent/create.yml
Outdated
| @@ -3,7 +3,7 @@ | |||
| hosts: localhost | |||
| connection: local | |||
| gather_facts: false | |||
| no_log: "{{ not lookup('env', 'MOLECULE_DEBUG') | bool }}" | |||
There was a problem hiding this comment.
Can I ask why? I think it's useful when problems arise testing in local
There was a problem hiding this comment.
Good catch, I disabled that while testing. I'll re-enable it. :)
| @@ -47,7 +47,7 @@ | |||
| delegate_to: localhost | |||
|
|
|||
| - name: Copy vars in json to remote | |||
| template: | |||
| copy: | |||
There was a problem hiding this comment.
IMO, if we're changing template to copy, then we should remove the .j2 extension from the file.
There was a problem hiding this comment.
That was a weird scenario. I did the change to help improve the yamllint score on Ansible Galaxy. It looks like Ansible Galaxy is ignoring the .yamllint exectpions.
jnogol
requested review from
sorobon,
jnogol,
dortegau,
frantsao,
jmonterrubio,
jperera and
miguel-chacon
|
Superseded by #62. Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Massive updates, and the build is now fixed.
Benefits
Possible Drawbacks
None
Applicable Issues
Add functionality per #59