Added error to prevent segfault in DebugResidualAux #29920
+167
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job Documentation, step Docs: sync website on 322d92f wanted to post the following: View the site here This comment will be updated on new commits. |
|
Job Coverage, step Generate coverage on 322d92f wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||
-Added check in DebugResidualAux constructor that checks that order and family parameters match for var and aux var -Added basic test for DebugAuxillaryAux -Added DebugResidualAux test that checks to ensure error is throw when order/family params don't match closes idaholab#27633
DanielYankura
force-pushed
the
DebugResidualAux_SegFaul
branch
from
c8081a4 to
322d92f
Compare
GiudGiud
reviewed
Feb 20, 2025
Comment on lines
7
to
8
| requirement = "The system shall have the ability to create an auxillary variable that keeps track of another variable's residuals." | ||
| [errors] |
There was a problem hiding this comment.
Suggested change
| requirement = "The system shall have the ability to create an auxillary variable that keeps track of another variable's residuals." | |
| [errors] | |
| requirement = "The system shall have the ability to create an auxillary variable that keeps track of another variable's residuals." | |
| [] | |
| [errors] |
There was a problem hiding this comment.
I d delete the first one. there is already a test for this auxkernel as code coverage shows
There was a problem hiding this comment.
If you want I can move that test over into the debug_residual_aux folder. That way on the docs page for this auxkernel it will have the two tests listed, now just the one that tests the error catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
-Makes debugging input file easier
Design
-Added check in DebugResidualAux constructor that checks that order and family parameters match for var and aux var
-Added basic test for DebugAuxillaryAux
-Added DebugResidualAux test that checks to ensure error is throw when order/family params don't match
Impact
Less time spent on user support
closes #27633