Add enthalpy solve capability to linear FV fluid heat transfer physics #29919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiudGiud
force-pushed
the
PR_physics_h
branch
2 times, most recently
from
84fa270 to
80065e6
Compare
…transfer Physics refs idaholab#29531
GiudGiud
force-pushed
the
PR_physics_h
branch
from
80065e6 to
75e4b18
Compare
|
Job Documentation, step Docs: sync website on 80fb484 wanted to post the following: View the site here This comment will be updated on new commits. |
|
Job Coverage, step Generate coverage on 80fb484 wanted to post the following: Framework coverageCoverage did not change Modules coverageNavier stokes
Phase field
Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||||||||||||||||||||||||||||
lindsayad
requested changes
Feb 24, 2025
Comment on lines
83
to
87
| [AuxVariables] | ||
| [T] | ||
| type = MooseLinearVariableFVReal | ||
| [] | ||
| [] |
There was a problem hiding this comment.
The physics can auto-create this right? This is just for testing?
There was a problem hiding this comment.
not right now. Maybe later
There was a problem hiding this comment.
I'd also vote for including this in the physics.
modules/navier_stokes/test/tests/finite_volume/wcns/enthalpy_equation/tests
Outdated
Show resolved
Hide resolved
grmnptr
reviewed
Feb 24, 2025
modules/navier_stokes/src/physics/WCNSLinearFVFluidHeatTransferPhysics.C
Show resolved
Hide resolved
- create an aux T variable when solving for enthalpy if it does not exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #29531
notice how the setup does not require much understanding of passing functors through other functors etc