Merge pull request #28515 from DanielYankura/fix_for_26714

Improves error message for invalid dump parameter
idaholab · Sep 5, 2024 · 9a6b276 · 9a6b276
2 parents af0579a + 84b3c43
commit 9a6b276
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 6 deletions.
diff --git a/framework/src/base/MooseApp.C b/framework/src/base/MooseApp.C
@@ -820,13 +820,19 @@ MooseApp::setupOptions()
       _builder.buildJsonSyntaxTree(tree);
     }
 
-    // Turn off live printing so that it doesn't mess with the dump
-    _perf_graph.disableLivePrint();
+    // Check if second arg is valid or not
+    if ((tree.getRoot()).is_object())
+    {
+      // Turn off live printing so that it doesn't mess with the dump
+      _perf_graph.disableLivePrint();
 
-    JsonInputFileFormatter formatter;
-    Moose::out << "\n### START DUMP DATA ###\n"
-               << formatter.toString(tree.getRoot()) << "\n### END DUMP DATA ###" << std::endl;
-    _ready_to_exit = true;
+      JsonInputFileFormatter formatter;
+      Moose::out << "\n### START DUMP DATA ###\n"
+                 << formatter.toString(tree.getRoot()) << "\n### END DUMP DATA ###" << std::endl;
+      _ready_to_exit = true;
+    }
+    else
+      mooseError("Search parameter '", param_search, "' was not found in the registered syntax.");
   }
   else if (isParamValid("registry"))
   {

diff --git a/test/tests/misc/check_error/tests b/test/tests/misc/check_error/tests
@@ -1169,4 +1169,13 @@
     design = 'MooseUtils.md'
     issues = '#17407'
   []
+  [dump_error_with_unrecogized_param]
+    type = 'RunException'
+    input = ''
+    cli_args = '--dump bad_parameter'
+    expect_err = "Search parameter 'bad_parameter' was not found in the registered syntax."
+
+    requirement = 'The system shall report a helpful error when the dump parameter does not match any valid parameters'
+    issues = '#26714'
+  []
 []