Adding MaterialRealCMMAux and some other changes. #376

cbolisetti · 2021-06-10T17:24:20Z

Makes the following changes/additions:

Add the MaterialRealCMMAux, tests, and doco.
Changes to linear spring material property variables to convert them to ColumnMajorMatrix instead, so that they are consistent with isolator materials.
Other miscellaneous changes and addressing a doco bug.

Closes #374 #356 and #326

moosebuild · 2021-06-10T19:09:34Z

Job Test on 217598f wanted to post the following:

View the site here

This comment will be updated on new commits.

cbolisetti · 2021-06-10T20:51:28Z

@somu15 can you please review this?

somu15

@cbolisetti I did an initial review. Let me know if you have any questions.

somu15 · 2021-06-11T22:24:25Z

doc/content/source/auxkernels/MaterialRealCMMAux.md

+a material property that is of type, ColumnMajorMatrix (CMM). In MASTODON, a
+common use case is accessing the deformation or force CMMs from link elements
+when the [`LinearSpring`](source/materials/LinearSpring.md) material or any of
+the seismic isolator materials (e.g., [`ComputeFPIsolatorElasticity`](source/materials/ComputeFPIsolatorElasticity.md)) is used. This `AuxKernel` and the corresponding


Does this mean we can directly get the isolator deformations without having to do a difference between top and bottom node displacements? If so, can you please state this explicitly so that the benefits of this auxkernel are clearer?

somu15 · 2021-06-11T22:29:31Z

src/auxkernels/MaterialRealCMMAux.C

+  InputParameters params = MaterialAuxBase<>::validParams();
+  params.addClassDescription(
+      "Populate an auxiliary variable with an entry from a ColumnMajorMatrix material property.");
+  params.addParam<unsigned int>("row", 0, "The row component to consider for this kernel");


How will the user know which row to use here?

somu15 · 2021-06-11T22:29:50Z

src/auxkernels/MaterialRealCMMAux.C

+  params.addClassDescription(
+      "Populate an auxiliary variable with an entry from a ColumnMajorMatrix material property.");
+  params.addParam<unsigned int>("row", 0, "The row component to consider for this kernel");
+  params.addParam<unsigned int>("column", 0, "The column component to consider for this kernel");


Similar to previous, how to know which column to use?

somu15 · 2021-06-11T22:32:32Z

src/kernels/StressDivergenceDamper.C

@@ -33,8 +33,8 @@ StressDivergenceDamper::StressDivergenceDamper(const InputParameters & parameter
    _component(getParam<unsigned int>("component")),
    _ndisp(coupledComponents("displacements")),
    _disp_var(_ndisp),
-    _Fg(getMaterialPropertyByName<ColumnMajorMatrix>("global_forces")),
-    _Kg(getMaterialPropertyByName<ColumnMajorMatrix>("global_stiffness_matrix"))
+    _Fg(getMaterialPropertyByName<ColumnMajorMatrix>("fvd_global_forces")),


You are changing these names so that there is consistency across all line type materials? Like Spring, Isolator, etc.?

somu15 · 2021-06-11T22:33:29Z

src/materials/ComputeLRIsolatorElasticity.C

-    _total_gl(getMaterialPropertyByName<ColumnMajorMatrix>("total_global_to_local_transformation")),
-    _total_lb(getMaterialPropertyByName<ColumnMajorMatrix>("total_local_to_basic_transformation")),
-    _length(getMaterialPropertyByName<Real>("initial_isolator_length")),
+    _basic_def(getMaterialPropertyByName<ColumnMajorMatrix>("si_deformations")),


Can you please explain the reason for changing these names?

…h Isolators. This also helps use the MaterialRealCMMAux Auxkernel to get forces and deformations of the spring. Refs idaholab#376.

moosebuild · 2021-06-12T00:10:06Z

Job Precheck on 2199c99 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/mastodon/docs/PRs/376/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format a9ccdaf6572ceb7b112cd8e5c95d699ca19aa57d

cbolisetti · 2021-06-12T00:11:55Z

@somu15 thanks for the review. I was going to remove the commits on changes in material properties, but I forgot -- my bad. Those were supposed to address #356. I am not yet sure what the solution for that is, but I will leave it for now. Please check out the commits now. I added some more detail in the auxkernel doco. Note that this is similar to the RankTwoTensor auxkernel, in which the user needs to know which component of the tensor corresponds to which stress component, etc. I added some language about this in the end.

…loses idaholab#326.

somu15

@cbolisetti This looks good. One comment is, if the user requests a row/column value outside the validity range, do you want to throw a moose error in the auxkernel? Or else, what is your thought on this?

somu15 · 2021-06-21T20:57:22Z

doc/content/source/auxkernels/MaterialRealCMMAux.md

+
+!listing test/tests/auxkernels/materialrealcmm/spring_static.i block=AuxKernels
+
+In this input, the AuxKernel takes the element (0, 0) from the CMM material property named, "global_forces" in the linear spring material. (See LinearSpring.C for other material properties.) In this example, the linear spring material is only defined in block '0' and therefore this AuxKernel and AuxVariable are also restricted to this block. The element (0, 0) of the material property "global_forces" corresponds to the axial force in the spring. Currently, in order to know what each of the elements in a material property CMM correspond to, users will either have to go through the source code or reach out to one of the MASTODON developers [here](help/contact_us.md). 


This information is very helpful to the users.

cbolisetti · 2021-06-21T21:04:51Z

@cbolisetti This looks good. One comment is, if the user requests a row/column value outside the validity range, do you want to throw a moose error in the auxkernel? Or else, what is your thought on this?

@somu15 yes, the AuxKernel will throw an error when that happens. See lines 42 and 43 of MaterialRealCMMAux.C

somu15 · 2021-06-21T21:06:38Z

@cbolisetti This looks good. One comment is, if the user requests a row/column value outside the validity range, do you want to throw a moose error in the auxkernel? Or else, what is your thought on this?

@somu15 yes, the AuxKernel will throw an error when that happens. See lines 42 and 43 of MaterialRealCMMAux.C

Sounds good! Thanks for the clarification.

cbolisetti requested a review from somu15 June 10, 2021 20:51

cbolisetti force-pushed the cmmaux branch from 21b94e0 to bceccd2 Compare June 10, 2021 21:37

somu15 reviewed Jun 11, 2021

View reviewed changes

cbolisetti added 5 commits June 11, 2021 17:36

Changing material property type in Linear spring to be compatible wit…

c82f6ef

…h Isolators. This also helps use the MaterialRealCMMAux Auxkernel to get forces and deformations of the spring. Refs idaholab#376.

Added MaterialRealCMMAux auxkernel. Refs idaholab#376.

45dd85c

Adding tests for MateralRealCMMAux. Refs idaholab#376.

7748e8c

Adding doco for MaterialRealCMMAux. Closes idaholab#376.

e66bf46

Addressing @somu15 comments.

1fd37bd

cbolisetti force-pushed the cmmaux branch from bceccd2 to 1fd37bd Compare June 12, 2021 00:04

Fixing material parameter description in computeLRIslatorElasticity. C…

217598f

…loses idaholab#326.

cbolisetti force-pushed the cmmaux branch from 2199c99 to 217598f Compare June 12, 2021 00:13

somu15 reviewed Jun 21, 2021

View reviewed changes

somu15 approved these changes Jun 21, 2021

View reviewed changes

cbolisetti merged commit dfb8fbb into idaholab:devel Jun 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding MaterialRealCMMAux and some other changes. #376

Adding MaterialRealCMMAux and some other changes. #376

cbolisetti commented Jun 10, 2021 •

edited

Loading

moosebuild commented Jun 10, 2021 •

edited

Loading

cbolisetti commented Jun 10, 2021

somu15 left a comment

somu15 Jun 11, 2021

somu15 Jun 11, 2021

somu15 Jun 11, 2021

somu15 Jun 11, 2021

somu15 Jun 11, 2021

moosebuild commented Jun 12, 2021

cbolisetti commented Jun 12, 2021

somu15 left a comment

somu15 Jun 21, 2021

cbolisetti commented Jun 21, 2021

somu15 commented Jun 21, 2021


		!listing test/tests/auxkernels/materialrealcmm/spring_static.i block=AuxKernels

		In this input, the AuxKernel takes the element (0, 0) from the CMM material property named, "global_forces" in the linear spring material. (See LinearSpring.C for other material properties.) In this example, the linear spring material is only defined in block '0' and therefore this AuxKernel and AuxVariable are also restricted to this block. The element (0, 0) of the material property "global_forces" corresponds to the axial force in the spring. Currently, in order to know what each of the elements in a material property CMM correspond to, users will either have to go through the source code or reach out to one of the MASTODON developers [here](help/contact_us.md).

Adding MaterialRealCMMAux and some other changes. #376

Adding MaterialRealCMMAux and some other changes. #376

Conversation

cbolisetti commented Jun 10, 2021 • edited Loading

moosebuild commented Jun 10, 2021 • edited Loading

cbolisetti commented Jun 10, 2021

somu15 left a comment

Choose a reason for hiding this comment

somu15 Jun 11, 2021

Choose a reason for hiding this comment

somu15 Jun 11, 2021

Choose a reason for hiding this comment

somu15 Jun 11, 2021

Choose a reason for hiding this comment

somu15 Jun 11, 2021

Choose a reason for hiding this comment

somu15 Jun 11, 2021

Choose a reason for hiding this comment

moosebuild commented Jun 12, 2021

cbolisetti commented Jun 12, 2021

somu15 left a comment

Choose a reason for hiding this comment

somu15 Jun 21, 2021

Choose a reason for hiding this comment

cbolisetti commented Jun 21, 2021

somu15 commented Jun 21, 2021

cbolisetti commented Jun 10, 2021 •

edited

Loading

moosebuild commented Jun 10, 2021 •

edited

Loading