Fullapp reentering fix #372

YaqiWang · 2019-02-08T19:51:23Z

A fix for a MOOSE PR idaholab/moose#12773. That PR allows a wrapped transient run with FullSolveMultiApp to reenter properly. I saw with that PR, MyTRIM gets executed twice instead of once before. I think this is the right behavior but need you to confirm. Tag @snschune and @dschwen .

I did not see MOOSE submodule in magpie, so cannot do a submodule update along this PR. For the same reason, I marked this PR as WIP. I will remove WIP after the PR in MOOSE gets merged. Thanks.

YaqiWang · 2019-02-08T19:56:48Z

FYI, this is the screen output before:

Executing MultiApps on NONLINEAR
radiation_damage_app0: 
radiation_damage_app0: Time Step 1, time = 1
radiation_damage_app0:                 dt = 1
radiation_damage_app0: 
radiation_damage_app0: 
radiation_damage_app0: MyTRIM: Running 52 recoils.
radiation_damage_app0: Recoil rate scaling factor is 1
radiation_damage_app0: Sampled number of recoils: 52
radiation_damage_app0: Result scaling factor: 1
radiation_damage_app0:  0 Nonlinear |R| = 0.000000e+00
radiation_damage_app0:  Solve Converged!
radiation_damage_app0: 
radiation_damage_app0: Postprocessor Values:
radiation_damage_app0: +----------------+----------------+----------------+----------------+----------------+----------------+----------------+----------------+
radiation_damage_app0: | time           | int_C_pp       | int_O_pp       | int_U_pp       | n_pkas         | vac_C_pp       | vac_O_pp       | vac_U_pp       |
radiation_damage_app0: +----------------+----------------+----------------+----------------+----------------+----------------+----------------+----------------+
radiation_damage_app0: |   0.000000e+00 |   0.000000e+00 |   0.000000e+00 |   0.000000e+00 |   0.000000e+00 |   0.000000e+00 |   0.000000e+00 |   0.000000e+00 |
radiation_damage_app0: |   1.000000e+00 |   4.231060e+05 |   9.136770e+05 |   5.462510e+05 |   0.000000e+00 |   4.223770e+05 |   9.144060e+05 |   5.462480e+05 |
radiation_damage_app0: +----------------+----------------+----------------+----------------+----------------+----------------+----------------+----------------+
radiation_damage_app0: 
Finished Executing MultiApps on NONLINEAR


No Transfers on NONLINEAR To MultiApps

      0 Linear |R| = 3.000000e+00
      1 Linear |R| = 5.253504e-01
      2 Linear |R| = 1.161749e-01
      3 Linear |R| = 2.968344e-02
      4 Linear |R| = 5.048029e-03
      5 Linear |R| = 5.622536e-04
      6 Linear |R| = 6.094379e-05
      7 Linear |R| = 4.070143e-06
 1 Nonlinear |R| = 4.070143e-06

Starting Transfers on NONLINEAR To MultiApps
Transfers on NONLINEAR Are Finished


Executing MultiApps on NONLINEAR
Finished Executing MultiApps on NONLINEAR


No Transfers on NONLINEAR To MultiApps

      0 Linear |R| = 4.070143e-06
      1 Linear |R| = 4.129165e-07
      2 Linear |R| = 5.648132e-08
      3 Linear |R| = 1.881637e-08
      4 Linear |R| = 3.168601e-09
      5 Linear |R| = 4.088525e-10
      6 Linear |R| = 5.330095e-11
      7 Linear |R| = 5.226867e-12
 2 Nonlinear |R| = 5.226734e-12
 Solve Converged!

You can notice that there is nothing in the second multiapp run.
And after

Executing MultiApps on NONLINEAR
radiation_damage_app0: 
radiation_damage_app0: Postprocessor Values:
radiation_damage_app0: +----------------+----------------+----------------+----------------+----------------+----------------+----------------+----------------+
radiation_damage_app0: | time           | int_C_pp       | int_O_pp       | int_U_pp       | n_pkas         | vac_C_pp       | vac_O_pp       | vac_U_pp       |
radiation_damage_app0: +----------------+----------------+----------------+----------------+----------------+----------------+----------------+----------------+
radiation_damage_app0: |   0.000000e+00 |   0.000000e+00 |   0.000000e+00 |   0.000000e+00 |   0.000000e+00 |   0.000000e+00 |   0.000000e+00 |   0.000000e+00 |
radiation_damage_app0: +----------------+----------------+----------------+----------------+----------------+----------------+----------------+----------------+
radiation_damage_app0: 
radiation_damage_app0: 
radiation_damage_app0: Time Step 1, time = 1
radiation_damage_app0:                 dt = 1
radiation_damage_app0: 
radiation_damage_app0: 
radiation_damage_app0: MyTRIM: Running 52 recoils.
radiation_damage_app0: Recoil rate scaling factor is 1
radiation_damage_app0: Sampled number of recoils: 52
radiation_damage_app0: Result scaling factor: 1
radiation_damage_app0:  0 Nonlinear |R| = 0.000000e+00
radiation_damage_app0:  Solve Converged!
radiation_damage_app0: 
radiation_damage_app0: Postprocessor Values:
radiation_damage_app0: +----------------+----------------+----------------+----------------+----------------+----------------+----------------+----------------+
radiation_damage_app0: | time           | int_C_pp       | int_O_pp       | int_U_pp       | n_pkas         | vac_C_pp       | vac_O_pp       | vac_U_pp       |
radiation_damage_app0: +----------------+----------------+----------------+----------------+----------------+----------------+----------------+----------------+
radiation_damage_app0: |   0.000000e+00 |   0.000000e+00 |   0.000000e+00 |   0.000000e+00 |   0.000000e+00 |   0.000000e+00 |   0.000000e+00 |   0.000000e+00 |
radiation_damage_app0: |   1.000000e+00 |   4.231060e+05 |   9.136770e+05 |   5.462510e+05 |   0.000000e+00 |   4.223770e+05 |   9.144060e+05 |   5.462480e+05 |
radiation_damage_app0: +----------------+----------------+----------------+----------------+----------------+----------------+----------------+----------------+
radiation_damage_app0: 
Finished Executing MultiApps on NONLINEAR


No Transfers on NONLINEAR To MultiApps

      0 Linear |R| = 3.000000e+00
      1 Linear |R| = 5.253504e-01
      2 Linear |R| = 1.161749e-01
      3 Linear |R| = 2.968344e-02
      4 Linear |R| = 5.048029e-03
      5 Linear |R| = 5.622536e-04
      6 Linear |R| = 6.094379e-05
      7 Linear |R| = 4.070143e-06
 1 Nonlinear |R| = 4.070143e-06

Starting Transfers on NONLINEAR To MultiApps
Transfers on NONLINEAR Are Finished


Executing MultiApps on NONLINEAR
radiation_damage_app0: 
radiation_damage_app0: Postprocessor Values:
radiation_damage_app0: +----------------+----------------+----------------+----------------+----------------+----------------+----------------+----------------+
radiation_damage_app0: | time           | int_C_pp       | int_O_pp       | int_U_pp       | n_pkas         | vac_C_pp       | vac_O_pp       | vac_U_pp       |
radiation_damage_app0: +----------------+----------------+----------------+----------------+----------------+----------------+----------------+----------------+
radiation_damage_app0: |   0.000000e+00 |   4.231060e+05 |   9.136770e+05 |   5.462510e+05 |   0.000000e+00 |   4.223770e+05 |   9.144060e+05 |   5.462480e+05 |
radiation_damage_app0: +----------------+----------------+----------------+----------------+----------------+----------------+----------------+----------------+
radiation_damage_app0: 
radiation_damage_app0: 
radiation_damage_app0: Time Step 1, time = 1
radiation_damage_app0:                 dt = 1
radiation_damage_app0: 
radiation_damage_app0: 
radiation_damage_app0: MyTRIM: Running 32 recoils.
radiation_damage_app0: Recoil rate scaling factor is 1
radiation_damage_app0: Sampled number of recoils: 32
radiation_damage_app0: Result scaling factor: 1
radiation_damage_app0:  0 Nonlinear |R| = 0.000000e+00
radiation_damage_app0:  Solve Converged!
radiation_damage_app0: 
radiation_damage_app0: Postprocessor Values:
radiation_damage_app0: +----------------+----------------+----------------+----------------+----------------+----------------+----------------+----------------+
radiation_damage_app0: | time           | int_C_pp       | int_O_pp       | int_U_pp       | n_pkas         | vac_C_pp       | vac_O_pp       | vac_U_pp       |
radiation_damage_app0: +----------------+----------------+----------------+----------------+----------------+----------------+----------------+----------------+
radiation_damage_app0: |   0.000000e+00 |   4.231060e+05 |   9.136770e+05 |   5.462510e+05 |   0.000000e+00 |   4.223770e+05 |   9.144060e+05 |   5.462480e+05 |
radiation_damage_app0: |   1.000000e+00 |   3.573110e+05 |   3.266300e+05 |   1.974080e+05 |   0.000000e+00 |   3.568680e+05 |   3.270730e+05 |   1.974070e+05 |
radiation_damage_app0: +----------------+----------------+----------------+----------------+----------------+----------------+----------------+----------------+
radiation_damage_app0: 
Finished Executing MultiApps on NONLINEAR


No Transfers on NONLINEAR To MultiApps

      0 Linear |R| = 4.070143e-06
      1 Linear |R| = 4.129165e-07
      2 Linear |R| = 5.648132e-08
      3 Linear |R| = 1.881637e-08
      4 Linear |R| = 3.168601e-09
      5 Linear |R| = 4.088525e-10
      6 Linear |R| = 5.330095e-11
      7 Linear |R| = 5.226867e-12
 2 Nonlinear |R| = 5.226734e-12
 Solve Converged!

dschwen · 2019-02-13T23:30:00Z

tests/radiation_damage/coupled_fission_mockup/damage_sub.i

@@ -136,7 +136,6 @@
 [UserObjects]
  [./neutronics_fission_generator]
    type = PKAFissionFragmentNeutronics
-    relative_density = 1


Why is this change here?

This is not a valid parameter of PKAFissionFragmentNeutronics. We have a warning during run-time saying a unused param is detected.

YaqiWang · 2019-02-14T22:22:47Z

I think this is ready for merging. Be warned that @permcody 's PR idaholab/moose#12771 breaks Magpie.

dschwen · 2019-02-14T22:28:59Z

ERROR: Your patch does not contain a valid ticket reference! (i.e. #1234) M

YaqiWang · 2019-02-14T22:36:50Z

This closes #377.

moosebuild · 2019-02-14T22:40:16Z

Job Precheck on 8bdc2e5 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s http://mooseframework.inl.gov/magpie/docs/PRs/372/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 8bd81b069d10c4f78dfd40eff53330e3c2dfd657

idaholab#377

YaqiWang · 2019-02-14T23:07:52Z

@dschwen I did not see a moose submodule, so the question is which moose is the test against?

dschwen · 2019-07-01T15:21:52Z

There now is a MOOSE submodule.

moosebuild · 2020-06-04T23:12:35Z

Job Test on 69362a8 : invalidated by @dschwen

Retesting

moosebuild · 2020-06-05T00:07:34Z

Job Test on 69362a8 wanted to post the following:

View the site here

This comment will be updated on new commits.

dschwen · 2020-06-08T20:20:54Z

@YaqiWang this is over a year old. I this still needed?

YaqiWang · 2020-06-08T20:23:54Z

I assume if MOOSE is up to date, that test will fail. Is that the case? Geese, I thought this had been merged long ago...

moosebuild · 2020-10-06T03:47:19Z

All jobs on 69362a8 : invalidated by @dschwen

moosebuild · 2020-10-27T20:05:31Z

All jobs on 69362a8 : invalidated by @dschwen

dschwen · 2020-10-27T21:31:02Z

App test Mammoth is failing with an unrelated failure. I don't think I understand your last comment @YaqiWang, are apptests supposed to fail without this PR?

YaqiWang · 2020-10-27T21:58:48Z

This patch is needed for a change in MOOSE. So if your MOOSE is up to date, the regolded test in this PR will fail without this PR. You can verify this. This PR is supposed to fix that failure. I am not expecting an app test failure. I do not have the access to the test results.

dschwen

F it, I'm meeting this!

dschwen reviewed Feb 13, 2019

View reviewed changes

YaqiWang changed the title ~~WIP: Fullapp reentering fix~~ Fullapp reentering fix Feb 14, 2019

YaqiWang force-pushed the fullapp_reentering_fix branch from 8dc6f4b to 8bdc2e5 Compare February 14, 2019 22:36

YaqiWang force-pushed the fullapp_reentering_fix branch from 8bdc2e5 to 218236f Compare February 14, 2019 22:42

YaqiWang added 2 commits February 14, 2019 15:42

fix few run-time warnings

c890989

regold this test because now MOOSE FullSolveMultiApp allows re-entering

69362a8

idaholab#377

YaqiWang force-pushed the fullapp_reentering_fix branch from 218236f to 69362a8 Compare February 14, 2019 22:46

dschwen approved these changes Oct 31, 2020

View reviewed changes

dschwen merged commit beedbc3 into idaholab:devel Oct 31, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fullapp reentering fix #372

Fullapp reentering fix #372

YaqiWang commented Feb 8, 2019

YaqiWang commented Feb 8, 2019

dschwen Feb 13, 2019

YaqiWang Feb 13, 2019

YaqiWang commented Feb 14, 2019

dschwen commented Feb 14, 2019

YaqiWang commented Feb 14, 2019

moosebuild commented Feb 14, 2019

YaqiWang commented Feb 14, 2019

dschwen commented Jul 1, 2019

moosebuild commented Jun 4, 2020

moosebuild commented Jun 5, 2020

dschwen commented Jun 8, 2020

YaqiWang commented Jun 8, 2020

moosebuild commented Oct 6, 2020

moosebuild commented Oct 27, 2020

dschwen commented Oct 27, 2020

YaqiWang commented Oct 27, 2020

dschwen left a comment

Fullapp reentering fix #372

Fullapp reentering fix #372

Conversation

YaqiWang commented Feb 8, 2019

YaqiWang commented Feb 8, 2019

dschwen Feb 13, 2019

Choose a reason for hiding this comment

YaqiWang Feb 13, 2019

Choose a reason for hiding this comment

YaqiWang commented Feb 14, 2019

dschwen commented Feb 14, 2019

YaqiWang commented Feb 14, 2019

moosebuild commented Feb 14, 2019

YaqiWang commented Feb 14, 2019

dschwen commented Jul 1, 2019

moosebuild commented Jun 4, 2020

moosebuild commented Jun 5, 2020

dschwen commented Jun 8, 2020

YaqiWang commented Jun 8, 2020

moosebuild commented Oct 6, 2020

moosebuild commented Oct 27, 2020

dschwen commented Oct 27, 2020

YaqiWang commented Oct 27, 2020

dschwen left a comment

Choose a reason for hiding this comment