Skip to content

Comments

amd_smi: Remove carriage return#553

Merged
Treece-Burgess merged 1 commit intoicl-utk-edu:masterfrom
Treece-Burgess:02-03-2026-amd-smi-remove-carriage-return
Feb 19, 2026
Merged

amd_smi: Remove carriage return#553
Treece-Burgess merged 1 commit intoicl-utk-edu:masterfrom
Treece-Burgess:02-03-2026-amd-smi-remove-carriage-return

Conversation

@Treece-Burgess
Copy link
Contributor

@Treece-Burgess Treece-Burgess commented Feb 3, 2026

Pull Request Description

This pull request removes the carriage return from four files in amd_smi:

  • README.md
  • amds.h
  • tests/amdsmi_ctx_conflict.c
  • tests/amdsmi_energy_monotonic.c

Testing

For sanity sake, I tested on Odyssey at Oregon with ROCm 7.2.0, see below for results:

  • PAPI build: ✅
  • PAPI utilities*: ✅
  • amd_smi tests: ✅ (unable to test amdsmi_set_test.c as I lack the necessary permissions)

* - papi_component_avail, papi_native_avail, papi_command_line

Author Checklist

  • Description
    Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
  • Commits
    Commits are self contained and only do one thing
    Commits have a header of the form: module: short description
    Commits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
  • Tests
    The PR needs to pass all the tests

@Treece-Burgess Treece-Burgess added status-ready-for-review PR is ready to be reviewed type-maintenance Update code to keep it compatible, secure, modern. component-amd_smi PRs and Issues related to the amd_smi component labels Feb 3, 2026
@djwoun
Copy link
Contributor

djwoun commented Feb 18, 2026

Removing carriage returns and no functional changes.
Tested on ROCm 7.1.1 and 7.2.0 with amd_smi tests and papi utilities. Looks good to merge.

@Treece-Burgess Treece-Burgess force-pushed the 02-03-2026-amd-smi-remove-carriage-return branch from 0cb0c9c to e925c10 Compare February 19, 2026 00:15
@Treece-Burgess Treece-Burgess merged commit 27f0029 into icl-utk-edu:master Feb 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component-amd_smi PRs and Issues related to the amd_smi component status-ready-for-review PR is ready to be reviewed type-maintenance Update code to keep it compatible, secure, modern.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants