Skip to content

Comments

rocp_sdk tests: Add a runscript which can toggle desired events to be used and allow each test to be ran without command line args#530

Open
Treece-Burgess wants to merge 2 commits intoicl-utk-edu:masterfrom
Treece-Burgess:01-06-2026-update-rocp-sdk-tests
Open

rocp_sdk tests: Add a runscript which can toggle desired events to be used and allow each test to be ran without command line args#530
Treece-Burgess wants to merge 2 commits intoicl-utk-edu:masterfrom
Treece-Burgess:01-06-2026-update-rocp-sdk-tests

Conversation

@Treece-Burgess
Copy link
Contributor

@Treece-Burgess Treece-Burgess commented Jan 8, 2026

Pull Request Description

This PR updates the rocp_sdk component tests to:

  1. Take optional command line arguments to pass rocp_sdk native events
  2. If no optional rocp_sdk native events are provided via the command line we internally will enumerate through the available events on the architecture and ROCm version to get one

Along with the above two updates, the PR adds a run script which will run all four of the current tests for the rocp_sdk component. An optional flag --with-desired-events can be provided to this run script. Doing so will see the component tests ran with desired events listed in run_rocp_sdk_tests.sh.

Note: The desired events that had the DIMENSION_SHADER_ENGINE qualifier appended with a value greater than 3 were removed. As from testing with ROCm versions 7.0.1 and up these values did not exist anymore.

This partially closes Issue #524 as one other PR to update error codes is needed.

Testing

Setup

Testing was done on Odyssey at Oregon with the following setup:

  • OS: RHEL 8.10
  • CPU: MI300A
  • GPU: MI300A
  • ROCm versions: 6.4.4, 7.1.1, and 7.2.0 (pre-release)
  • PAPI Configure: ./configure --prefix=$PWD/test-install --with-components="rocp_sdk" --with-debug=yes

Results

  • advanced, simple, simple_sampling, and two_eventsets all passed without providing event names on the command line*
  • advanced, simple, simple_sampling, and two_eventsets all passed when providing event names on the command line*

* - For ROCm 7.2.0 two_eventsets.c shows zero values for events which previously did not have zero values this is a separate issue and will be looked into)

Author Checklist

  • Description
    Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
  • Commits
    Commits are self contained and only do one thing
    Commits have a header of the form: module: short description
    Commits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
  • Tests
    The PR needs to pass all the tests

… used and allow each test to be ran without command line arguments
@Treece-Burgess Treece-Burgess requested a review from dbarry9 January 8, 2026 15:43
@Treece-Burgess Treece-Burgess added status-ready-for-review PR is ready to be reviewed component-rocp_sdk PRs and Issues related to the rocp_sdk component type-maintenance Update code to keep it compatible, secure, modern. labels Jan 8, 2026
@Treece-Burgess
Copy link
Contributor Author

Please review PR #531 first such that I can rebase it on top of this PR.

@djwoun djwoun mentioned this pull request Feb 2, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component-rocp_sdk PRs and Issues related to the rocp_sdk component status-ready-for-review PR is ready to be reviewed type-maintenance Update code to keep it compatible, secure, modern.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant