rocp_sdk tests: Add a runscript which can toggle desired events to be used and allow each test to be ran without command line args#530
Open
Treece-Burgess wants to merge 2 commits intoicl-utk-edu:masterfrom
Conversation
… used and allow each test to be ran without command line arguments
Contributor
Author
|
Please review PR #531 first such that I can rebase it on top of this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR updates the
rocp_sdkcomponent tests to:rocp_sdknative eventsrocp_sdknative events are provided via the command line we internally will enumerate through the available events on the architecture and ROCm version to get oneAlong with the above two updates, the PR adds a run script which will run all four of the current tests for the
rocp_sdkcomponent. An optional flag--with-desired-eventscan be provided to this run script. Doing so will see the component tests ran with desired events listed inrun_rocp_sdk_tests.sh.Note: The desired events that had the
DIMENSION_SHADER_ENGINEqualifier appended with a value greater than 3 were removed. As from testing with ROCm versions 7.0.1 and up these values did not exist anymore.This partially closes Issue #524 as one other PR to update error codes is needed.
Testing
Setup
Testing was done on Odyssey at Oregon with the following setup:
./configure --prefix=$PWD/test-install --with-components="rocp_sdk" --with-debug=yesResults
advanced,simple,simple_sampling, andtwo_eventsetsall passed without providing event names on the command line*advanced,simple,simple_sampling, andtwo_eventsetsall passed when providing event names on the command line** - For ROCm 7.2.0
two_eventsets.cshows zero values for events which previously did not have zero values this is a separate issue and will be looked into)Author Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
The PR needs to pass all the tests