Open
Conversation
This was
linked to
issues
Jul 10, 2025
Contributor
|
I am reviewing this pull request. |
Treece-Burgess
added
status-work-in-progress
Treece-Burgess
force-pushed
the
07-10-25-libpfm3-removal
branch
from
6570f07 to
ef44e42
Compare
Treece-Burgess
added
status-ready-for-review
Treece-Burgess
commented
Aug 15, 2025
| { $as_echo "$as_me:${as_lineno-$LINENO}: XXXXX user_specified_interface perfnec" >&5 | ||
| if test "$user_specified_interface" = "pe"; then | ||
| PAPICFLAGS+=" $PECFLAGS" | ||
| perfnec=0 |
Contributor
Author
There was a problem hiding this comment.
Indent properly.
Contributor
|
src/Rules.pfm needs to also be removed. |
Contributor
Author
|
After discussion with Daniel, we are going to preemptively remove perfnec as from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The following commit removed perfctr and libpfm-3.y code. However, this commit left behind code that will not work without it such as the components
perfmon2andperfmon_ia64.This PR looks to remove the left behind code.
Testing
./configure --prefix=$PWD/test-installpapi_component_avail,papi_native_avail,papi_command_line, andpapi_availAuthor Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
The PR needs to pass all the tests