Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sprint 22/23 | PD-421] - [Enhancement] Use Jitsuyo For Utilities #28

Merged
merged 7 commits into from
Jun 24, 2024

Conversation

Mobilizes
Copy link
Contributor

Jira Link:

https://ichiro-its.atlassian.net/jira/software/c/projects/PD/boards/4?selectedIssue=PD-421

Description

Use jitsuyo repository to load and save config

Type of Change

  • Bugfix
  • Enhancement
  • New feature
  • Breaking change (fix or feature that would cause the existing functionality to not work as expected)

How Has This Been Tested?

  • New unit tests added.
  • Manual tested.

Checklist:

  • Using Branch Name Convention
    • feature/JIRA-ID-SHORT-DESCRIPTION if has a JIRA ticket
    • enhancement/SHORT-DESCRIPTION if has/has no JIRA ticket and contain enhancement
    • hotfix/SHORT-DESCRIPTION if the change doesn't need to be tested (urgent)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made the documentation for the corresponding changes.

include/shisen_cpp/camera/node/camera_node.hpp Outdated Show resolved Hide resolved
include/shisen_cpp/camera/provider/image_provider.hpp Outdated Show resolved Hide resolved
include/shisen_cpp/config/grpc/call_data.hpp Outdated Show resolved Hide resolved
include/shisen_cpp/config/grpc/config.hpp Outdated Show resolved Hide resolved
src/shisen_cpp_main.cpp Outdated Show resolved Hide resolved
src/viewer_main.cpp Outdated Show resolved Hide resolved
test/capture_setting_test.cpp Outdated Show resolved Hide resolved
test/compile_test.cpp Outdated Show resolved Hide resolved
test/emptiable_test.cpp Outdated Show resolved Hide resolved
@Mobilizes Mobilizes force-pushed the enhancement/use-jitsuyo-utils branch from d293c78 to a9b865a Compare June 21, 2024 17:43
@Mobilizes Mobilizes force-pushed the enhancement/use-jitsuyo-utils branch from d33a46e to 93bb0a7 Compare June 22, 2024 07:23
threeal
threeal previously approved these changes Jun 23, 2024
borednuna
borednuna previously approved these changes Jun 24, 2024
@Mobilizes Mobilizes dismissed stale reviews from borednuna and threeal via af13760 June 24, 2024 16:29
@Mobilizes Mobilizes force-pushed the enhancement/use-jitsuyo-utils branch from af13760 to f2f1372 Compare June 24, 2024 16:30
@Mobilizes Mobilizes merged commit 1a96543 into master Jun 24, 2024
1 check failed
@Mobilizes Mobilizes deleted the enhancement/use-jitsuyo-utils branch June 24, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants