⬆️ Update versions #174
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,4 +9,6 @@ build | |
| Pods | ||
| xcuserdata | ||
| local.properties | ||
| local.gradle | ||
| .kotlin | ||
| .DS_Store | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| #Tue Jun 10 21:09:29 CEST 2025 | ||
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.13-bin.zip | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,44 @@ | ||
| import io.gitlab.arturbosch.detekt.CONFIGURATION_DETEKT_PLUGINS | ||
|
|
||
| /* | ||
| * Copyright 2024 IceRock MAG Inc. Use of this source code is governed by the Apache 2.0 license. | ||
| */ | ||
|
|
||
| plugins { | ||
| id("org.jetbrains.kotlin.multiplatform") | ||
| id("com.android.library") | ||
| id("dev.icerock.moko.gradle.publication") | ||
| id("dev.icerock.moko.gradle.stub.javadoc") | ||
| alias(libs.plugins.detekt) | ||
| } | ||
|
|
||
| android { | ||
| namespace = "dev.icerock.moko.permissions.bluetooth" | ||
| compileSdk = 36 | ||
| } | ||
|
|
||
| kotlin { | ||
| applyDefaultHierarchyTemplate() | ||
|
|
||
| androidTarget { publishLibraryVariants("release", "debug") } | ||
|
|
||
| listOf( | ||
| iosX64(), | ||
| iosArm64(), | ||
| iosSimulatorArm64(), | ||
| ) | ||
|
Comment on lines
+21
to
+29
There was a problem hiding this comment. this should be from convention plugin too |
||
|
|
||
| sourceSets { | ||
| commonMain { | ||
| dependencies { | ||
| api(projects.permissions) | ||
| implementation(libs.coroutines) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| dependencies { | ||
| CONFIGURATION_DETEKT_PLUGINS(libs.detekt.cli) | ||
| CONFIGURATION_DETEKT_PLUGINS(libs.detekt.formatting) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,50 @@ | ||
| import io.gitlab.arturbosch.detekt.CONFIGURATION_DETEKT_PLUGINS | ||
|
|
||
| /* | ||
| * Copyright 2024 IceRock MAG Inc. Use of this source code is governed by the Apache 2.0 license. | ||
| */ | ||
|
|
||
| plugins { | ||
| id("org.jetbrains.kotlin.multiplatform") | ||
| id("com.android.library") | ||
| id("dev.icerock.moko.gradle.publication") | ||
| id("dev.icerock.moko.gradle.stub.javadoc") | ||
| alias(libs.plugins.detekt) | ||
| } | ||
|
|
||
| android { | ||
| namespace = "dev.icerock.moko.permissions.camera" | ||
| compileSdk = 36 | ||
| } | ||
|
|
||
| kotlin { | ||
| applyDefaultHierarchyTemplate() | ||
|
|
||
| androidTarget { publishLibraryVariants("release", "debug") } | ||
|
|
||
| listOf( | ||
| iosX64(), | ||
| iosArm64(), | ||
| iosSimulatorArm64(), | ||
| ) | ||
|
Comment on lines
+21
to
+29
There was a problem hiding this comment. this should be from convention plugin too |
||
|
|
||
| sourceSets { | ||
| commonMain { | ||
| dependencies { | ||
| api(projects.permissions) | ||
| implementation(libs.coroutines) | ||
| } | ||
| } | ||
|
|
||
| iosMain { | ||
| dependencies { | ||
| implementation(projects.permissionsAvfoundation) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| dependencies { | ||
| CONFIGURATION_DETEKT_PLUGINS(libs.detekt.cli) | ||
| CONFIGURATION_DETEKT_PLUGINS(libs.detekt.formatting) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,58 @@ | ||
| import io.gitlab.arturbosch.detekt.CONFIGURATION_DETEKT_PLUGINS | ||
|
|
||
| /* | ||
| * Copyright 2019 IceRock MAG Inc. Use of this source code is governed by the Apache 2.0 license. | ||
| */ | ||
|
|
||
| plugins { | ||
| id("org.jetbrains.kotlin.multiplatform") | ||
| id("org.jetbrains.kotlin.plugin.compose") | ||
| id("com.android.library") | ||
| id("dev.icerock.moko.gradle.publication") | ||
| id("dev.icerock.moko.gradle.stub.javadoc") | ||
| alias(libs.plugins.detekt) | ||
| id("org.jetbrains.compose") | ||
| } | ||
|
|
||
| android { | ||
| namespace = "dev.icerock.moko.permissions.compose" | ||
| compileSdk = 36 | ||
|
|
||
| defaultConfig { | ||
| minSdk = 21 | ||
| } | ||
| } | ||
|
|
||
| kotlin { | ||
| applyDefaultHierarchyTemplate() | ||
|
|
||
| androidTarget { publishLibraryVariants("release", "debug") } | ||
|
|
||
| listOf( | ||
| iosX64(), | ||
| iosArm64(), | ||
| iosSimulatorArm64(), | ||
| ) | ||
|
Comment on lines
+27
to
+35
There was a problem hiding this comment. this should be from convention plugin too |
||
|
|
||
| sourceSets { | ||
| commonMain { | ||
| dependencies { | ||
| api(projects.permissions) | ||
| api(compose.runtime) | ||
| } | ||
| } | ||
|
|
||
| androidMain { | ||
| dependencies { | ||
| implementation(libs.activity) | ||
| implementation(libs.composeUi) | ||
| implementation(libs.lifecycleRuntime) | ||
| } | ||
| } | ||
| } | ||
|
Comment on lines
+37
to
+52
There was a problem hiding this comment. what reason to change small version of dependency declaration to this one? |
||
|
|
||
| dependencies { | ||
| CONFIGURATION_DETEKT_PLUGINS(libs.detekt.cli) | ||
| CONFIGURATION_DETEKT_PLUGINS(libs.detekt.formatting) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,44 @@ | ||
| import io.gitlab.arturbosch.detekt.CONFIGURATION_DETEKT_PLUGINS | ||
|
|
||
| /* | ||
| * Copyright 2024 IceRock MAG Inc. Use of this source code is governed by the Apache 2.0 license. | ||
| */ | ||
|
|
||
| plugins { | ||
| id("org.jetbrains.kotlin.multiplatform") | ||
| id("com.android.library") | ||
| id("dev.icerock.moko.gradle.publication") | ||
| id("dev.icerock.moko.gradle.stub.javadoc") | ||
| alias(libs.plugins.detekt) | ||
| } | ||
|
|
||
| android { | ||
| namespace = "dev.icerock.moko.permissions.contacts" | ||
| compileSdk = 36 | ||
| } | ||
|
|
||
| kotlin { | ||
| applyDefaultHierarchyTemplate() | ||
|
|
||
| androidTarget { publishLibraryVariants("release", "debug") } | ||
|
|
||
| listOf( | ||
| iosX64(), | ||
| iosArm64(), | ||
| iosSimulatorArm64(), | ||
| ) | ||
|
Comment on lines
+21
to
+29
There was a problem hiding this comment. this should be from convention plugin too |
||
|
|
||
| sourceSets { | ||
| commonMain { | ||
| dependencies { | ||
| api(projects.permissions) | ||
| implementation(libs.coroutines) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| dependencies { | ||
| CONFIGURATION_DETEKT_PLUGINS(libs.detekt.cli) | ||
| CONFIGURATION_DETEKT_PLUGINS(libs.detekt.formatting) | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if library will be compiled with kotlin 2.2.0 then users that use kotlin 2.0 or kotlin 1.9 will lost access to library.
i not see any reason to increase minimal kotlin version in this library. maybe you have some reasons?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure about this? I don't think upgrading to Kotlin 2.2.0 prevents users with lower versions from using the library 🤔
One important thing to note is that upgrading Kotlin improves many aspects of KMP in general in terms of configuration and setup.
This is the main reason why I upgraded to this version.
Also, upgrading to a newer version of Kotlin simply implies that if users want to use the latest release, they should also upgrade. Projects using KMP today should most likely not be using Kotlin versions lower than 2.0 🤔
Concerning all the other comments of using the configured moko plugins, since upgrading to Kotlin 2.2.0 changes various KMP configurations, these plugins would have to be upgraded beforehand which is why I didn't do it. If you want, I could take some time and update them but I'd need to be sure that upgrading to Kotlin 2+ is possible for you