Fix the initial candidate window position #2793
Open
+27
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2792
The issue is that the candidate window is already open when
InputMethod::Open
event is handled in the window manager. Sinceset_ime_cursor_area
is not called yet when the window is opened, the position of the window is at the top left corner.To fix this, we need to call
set_ime_cursor_area
earlier before the window is opened. winit's example calls the function just after callingset_ime_allowed
.This PR calls the function when allowing IME so
InputMethod::Allowed
event now has the position of the window.Here is the video:
fix.mp4