Remove the placeholder text when IME is activated in text input #2785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhysd
force-pushed
the
fix-placeholder-ime-pos
branch
from
23ed2b6 to
e4ff212
Compare
rhysd
changed the title
TextInput
rhysd
force-pushed
the
fix-placeholder-ime-pos
branch
from
e4ff212 to
eedaa37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes that the placeholder text is not removed when IME is activated.
Problem
When the preedit window is opened, the placeholder text is not removed. This is weird because the text input is already editing the content but the placeholder text is still there.
before.mp4
Solution
This PR removes the placeholder text when the input method is activated even if the text input content is not committed. This is the same behavior as
<input>element of web browsers.after.mp4