fix: singleton callback server for concurrent OAuth flows#278
Open
icebear0828 wants to merge 1 commit intomasterfrom
Open
fix: singleton callback server for concurrent OAuth flows#278icebear0828 wants to merge 1 commit intomasterfrom
icebear0828 wants to merge 1 commit intomasterfrom
Conversation
Previously each OAuth login created a new HTTP server on port 1455, closing the old one first — causing port conflicts and race conditions when multiple logins run concurrently. Now uses a singleton server with per-session callbacks (sessionCallbacks Map), idle timeout auto-close, and proper cleanup on session expiry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
startCallbackServer()→ensureCallbackServer()singleton patternsessionCallbacksMap by state, fully independentChanges
src/auth/oauth-pkce.ts: Singleton server, per-session callbacks, idle timeout, cleanup on session expiryTest plan
/auth/accounts/login