Merge pull request #312 from icatproject/payara6

Upgrade to JakartaEE 10 API for compatibility with Payara 6
icatproject · Sep 6, 2023 · c61f756 · c61f756
2 parents a9c5a89 + 24a81d8
commit c61f756
Show file tree

Hide file tree

Showing 90 changed files with 709 additions and 725 deletions.
diff --git a/.github/workflows/ci-build.yml b/.github/workflows/ci-build.yml
@@ -8,37 +8,29 @@ on:
 
 jobs:
   build_and_tests:
-    runs-on: ubuntu-20.04
-    continue-on-error: ${{ matrix.experimental }}
+    runs-on: ubuntu-22.04
     strategy:
-      fail-fast: false
       matrix:
-        include:
-          - version: 8
-            experimental: false
-          - version: 11
-            experimental: true
+        java_version: [11, 17]
 
     steps:
       # Setup Java & Python
       - name: Setup Java
         uses: actions/setup-java@v2
         with:
           distribution: 'temurin'
-          java-version: ${{ matrix.version }}
-      - name: Setup Python
-        uses: actions/setup-python@v2
-        with:
-          python-version: "3.9.7"
-          architecture: x64
+          java-version: ${{ matrix.java_version }}
+
+      - name: Run apt-get update
+        run: sudo apt-get update
 
       # ICAT Ansible clone and install dependencies
       - name: Checkout icat-ansible
         uses: actions/checkout@v2
         with:
           repository: icatproject-contrib/icat-ansible
           path: icat-ansible
-          ref: master
+          ref: payara6
       - name: Install Ansible
         run: pip install -r icat-ansible/requirements.txt
 

diff --git a/README.md b/README.md
@@ -4,6 +4,6 @@
 
 General installation instructions are at https://icatproject.org/installation/component
 
-Specific installation instructions are at https://repo.icatproject.org/site/icat/server/5.0.0/installation.html
+Specific installation instructions are at https://repo.icatproject.org/site/icat/server/6.0.0/installation.html
 
-All documentation on the icat.server may be found at https://repo.icatproject.org/site/icat/server/5.0.0
+All documentation on the icat.server may be found at https://repo.icatproject.org/site/icat/server/6.0.0
diff --git a/pom.xml b/pom.xml
@@ -3,7 +3,7 @@
 
 	<groupId>org.icatproject</groupId>
 	<artifactId>icat.server</artifactId>
-	<version>5.0.2-SNAPSHOT</version>
+	<version>6.0.1-SNAPSHOT</version>
 	<packaging>war</packaging>
 	<name>ICAT Server</name>
 	<description>A metadata catalogue to support Large Facility experimental data, 
@@ -71,16 +71,16 @@
 	<dependencies>
 
 		<dependency>
-			<groupId>javax</groupId>
-			<artifactId>javaee-api</artifactId>
-			<version>7.0</version>
+			<groupId>jakarta.platform</groupId>
+			<artifactId>jakarta.jakartaee-api</artifactId>
+			<version>10.0.0</version>
 			<scope>provided</scope>
 		</dependency>
 
 		<dependency>
 			<groupId>org.icatproject</groupId>
 			<artifactId>icat.authentication</artifactId>
-			<version>4.6.0</version>
+			<version>5.0.0</version>
 		</dependency>
 
 		<dependency>
@@ -96,18 +96,18 @@
 			<scope>test</scope>
 		</dependency>
 
-
 		<dependency>
-			<groupId>org.glassfish</groupId>
-			<artifactId>jakarta.json</artifactId>
-			<version>1.1.5</version>
+			<groupId>com.sun.xml.ws</groupId>
+			<artifactId>jaxws-rt</artifactId>
+			<version>4.0.0</version>
 			<scope>test</scope>
 		</dependency>
 
 		<dependency>
-			<groupId>commons-fileupload</groupId>
-			<artifactId>commons-fileupload</artifactId>
-			<version>1.4</version>
+			<groupId>org.eclipse.parsson</groupId>
+			<artifactId>parsson</artifactId>
+			<version>1.1.0</version>
+			<scope>test</scope>
 		</dependency>
 
 		<dependency>
@@ -119,7 +119,7 @@
 		<dependency>
 			<groupId>org.icatproject</groupId>
 			<artifactId>icat.client</artifactId>
-			<version>5.0.0</version>
+			<version>6.0.0</version>
 			<scope>test</scope>
 		</dependency>
 
@@ -159,7 +159,7 @@
 			<plugin>
 				<groupId>com.qmino</groupId>
 				<artifactId>miredot-plugin</artifactId>
-				<version>1.6.2</version>
+				<version>2.4.1-Java11</version>
 				<executions>
 					<execution>
 						<id>miredot</id>
@@ -260,21 +260,16 @@
 			<plugin>
 				<groupId>org.apache.maven.plugins</groupId>
 				<artifactId>maven-war-plugin</artifactId>
-				<version>2.4</version>
-				<configuration>
-					<failOnMissingWebXml>false</failOnMissingWebXml>
-					<archiveClasses>false</archiveClasses>
-				</configuration>
+				<version>3.4.0</version>
 			</plugin>
 
 			<plugin>
 				<groupId>org.apache.maven.plugins</groupId>
 				<artifactId>maven-compiler-plugin</artifactId>
-				<version>3.3</version>
+				<version>3.10.1</version>
 				<configuration>
 					<encoding>${project.build.sourceEncoding}</encoding>
-					<source>1.8</source>
-					<target>1.8</target>
+					<release>11</release>
 				</configuration>
 			</plugin>
 

diff --git a/src/main/java/org/icatproject/core/entity/Affiliation.java b/src/main/java/org/icatproject/core/entity/Affiliation.java
@@ -2,13 +2,13 @@
 
 import java.io.Serializable;
 
-import javax.persistence.Column;
-import javax.persistence.Entity;
-import javax.persistence.FetchType;
-import javax.persistence.JoinColumn;
-import javax.persistence.ManyToOne;
-import javax.persistence.Table;
-import javax.persistence.UniqueConstraint;
+import jakarta.persistence.Column;
+import jakarta.persistence.Entity;
+import jakarta.persistence.FetchType;
+import jakarta.persistence.JoinColumn;
+import jakarta.persistence.ManyToOne;
+import jakarta.persistence.Table;
+import jakarta.persistence.UniqueConstraint;
 
 @Comment("The home institute or other affiliation of a user in the context of a data publication")
 @SuppressWarnings("serial")

diff --git a/src/main/java/org/icatproject/core/entity/Application.java b/src/main/java/org/icatproject/core/entity/Application.java
@@ -4,15 +4,15 @@
 import java.util.ArrayList;
 import java.util.List;
 
-import javax.persistence.CascadeType;
-import javax.persistence.Column;
-import javax.persistence.Entity;
-import javax.persistence.FetchType;
-import javax.persistence.JoinColumn;
-import javax.persistence.ManyToOne;
-import javax.persistence.OneToMany;
-import javax.persistence.Table;
-import javax.persistence.UniqueConstraint;
+import jakarta.persistence.CascadeType;
+import jakarta.persistence.Column;
+import jakarta.persistence.Entity;
+import jakarta.persistence.FetchType;
+import jakarta.persistence.JoinColumn;
+import jakarta.persistence.ManyToOne;
+import jakarta.persistence.OneToMany;
+import jakarta.persistence.Table;
+import jakarta.persistence.UniqueConstraint;
 
 @Comment("Some piece of software")
 @SuppressWarnings("serial")

diff --git a/src/main/java/org/icatproject/core/entity/DataCollection.java b/src/main/java/org/icatproject/core/entity/DataCollection.java
@@ -4,9 +4,9 @@
 import java.util.ArrayList;
 import java.util.List;
 
-import javax.persistence.CascadeType;
-import javax.persistence.Entity;
-import javax.persistence.OneToMany;
+import jakarta.persistence.CascadeType;
+import jakarta.persistence.Entity;
+import jakarta.persistence.OneToMany;
 
 @Comment("A set of Investigations, Datasets and Datafiles which can span Facilities. "
 		+ "Note that it has no constraint fields. "

diff --git a/src/main/java/org/icatproject/core/entity/DataCollectionDatafile.java b/src/main/java/org/icatproject/core/entity/DataCollectionDatafile.java
@@ -2,12 +2,12 @@
 
 import java.io.Serializable;
 
-import javax.persistence.Entity;
-import javax.persistence.FetchType;
-import javax.persistence.JoinColumn;
-import javax.persistence.ManyToOne;
-import javax.persistence.Table;
-import javax.persistence.UniqueConstraint;
+import jakarta.persistence.Entity;
+import jakarta.persistence.FetchType;
+import jakarta.persistence.JoinColumn;
+import jakarta.persistence.ManyToOne;
+import jakarta.persistence.Table;
+import jakarta.persistence.UniqueConstraint;
 
 @Comment("Represents a many-to-many relationship between a DataCollection and its Datafiles.")
 @SuppressWarnings("serial")

diff --git a/src/main/java/org/icatproject/core/entity/DataCollectionDataset.java b/src/main/java/org/icatproject/core/entity/DataCollectionDataset.java
@@ -2,12 +2,12 @@
 
 import java.io.Serializable;
 
-import javax.persistence.Entity;
-import javax.persistence.FetchType;
-import javax.persistence.JoinColumn;
-import javax.persistence.ManyToOne;
-import javax.persistence.Table;
-import javax.persistence.UniqueConstraint;
+import jakarta.persistence.Entity;
+import jakarta.persistence.FetchType;
+import jakarta.persistence.JoinColumn;
+import jakarta.persistence.ManyToOne;
+import jakarta.persistence.Table;
+import jakarta.persistence.UniqueConstraint;
 
 @Comment("Represents a many-to-many relationship between a DataCollection and its datasets.")
 @SuppressWarnings("serial")

diff --git a/src/main/java/org/icatproject/core/entity/DataCollectionInvestigation.java b/src/main/java/org/icatproject/core/entity/DataCollectionInvestigation.java
@@ -2,12 +2,12 @@
 
 import java.io.Serializable;
 
-import javax.persistence.Entity;
-import javax.persistence.FetchType;
-import javax.persistence.JoinColumn;
-import javax.persistence.ManyToOne;
-import javax.persistence.Table;
-import javax.persistence.UniqueConstraint;
+import jakarta.persistence.Entity;
+import jakarta.persistence.FetchType;
+import jakarta.persistence.JoinColumn;
+import jakarta.persistence.ManyToOne;
+import jakarta.persistence.Table;
+import jakarta.persistence.UniqueConstraint;
 
 @Comment("Represents a many-to-many relationship between a DataCollection and its Investigations.")
 @SuppressWarnings("serial")

diff --git a/src/main/java/org/icatproject/core/entity/DataCollectionParameter.java b/src/main/java/org/icatproject/core/entity/DataCollectionParameter.java
@@ -2,12 +2,12 @@
 
 import java.io.Serializable;
 
-import javax.persistence.Entity;
-import javax.persistence.EntityManager;
-import javax.persistence.JoinColumn;
-import javax.persistence.ManyToOne;
-import javax.persistence.Table;
-import javax.persistence.UniqueConstraint;
+import jakarta.persistence.Entity;
+import jakarta.persistence.EntityManager;
+import jakarta.persistence.JoinColumn;
+import jakarta.persistence.ManyToOne;
+import jakarta.persistence.Table;
+import jakarta.persistence.UniqueConstraint;
 
 import org.icatproject.core.IcatException;
 import org.icatproject.core.manager.EntityBeanManager.PersistMode;

diff --git a/src/main/java/org/icatproject/core/entity/DataPublication.java b/src/main/java/org/icatproject/core/entity/DataPublication.java
@@ -5,17 +5,17 @@
 import java.util.Date;
 import java.util.List;
 
-import javax.persistence.CascadeType;
-import javax.persistence.Column;
-import javax.persistence.Entity;
-import javax.persistence.FetchType;
-import javax.persistence.JoinColumn;
-import javax.persistence.ManyToOne;
-import javax.persistence.OneToMany;
-import javax.persistence.Table;
-import javax.persistence.Temporal;
-import javax.persistence.TemporalType;
-import javax.persistence.UniqueConstraint;
+import jakarta.persistence.CascadeType;
+import jakarta.persistence.Column;
+import jakarta.persistence.Entity;
+import jakarta.persistence.FetchType;
+import jakarta.persistence.JoinColumn;
+import jakarta.persistence.ManyToOne;
+import jakarta.persistence.OneToMany;
+import jakarta.persistence.Table;
+import jakarta.persistence.Temporal;
+import jakarta.persistence.TemporalType;
+import jakarta.persistence.UniqueConstraint;
 
 @Comment("A curated data publication")
 @SuppressWarnings("serial")

diff --git a/src/main/java/org/icatproject/core/entity/DataPublicationDate.java b/src/main/java/org/icatproject/core/entity/DataPublicationDate.java
@@ -2,13 +2,13 @@
 
 import java.io.Serializable;
 
-import javax.persistence.Column;
-import javax.persistence.Entity;
-import javax.persistence.FetchType;
-import javax.persistence.JoinColumn;
-import javax.persistence.ManyToOne;
-import javax.persistence.Table;
-import javax.persistence.UniqueConstraint;
+import jakarta.persistence.Column;
+import jakarta.persistence.Entity;
+import jakarta.persistence.FetchType;
+import jakarta.persistence.JoinColumn;
+import jakarta.persistence.ManyToOne;
+import jakarta.persistence.Table;
+import jakarta.persistence.UniqueConstraint;
 
 @Comment("A date relevant for the publication")
 @SuppressWarnings("serial")

diff --git a/src/main/java/org/icatproject/core/entity/DataPublicationFunding.java b/src/main/java/org/icatproject/core/entity/DataPublicationFunding.java
@@ -2,12 +2,12 @@
 
 import java.io.Serializable;
 
-import javax.persistence.Entity;
-import javax.persistence.FetchType;
-import javax.persistence.JoinColumn;
-import javax.persistence.ManyToOne;
-import javax.persistence.Table;
-import javax.persistence.UniqueConstraint;
+import jakarta.persistence.Entity;
+import jakarta.persistence.FetchType;
+import jakarta.persistence.JoinColumn;
+import jakarta.persistence.ManyToOne;
+import jakarta.persistence.Table;
+import jakarta.persistence.UniqueConstraint;
 
 @Comment("Represents a many-to-many relationship between a data publication and a funding reference")
 @SuppressWarnings("serial")

diff --git a/src/main/java/org/icatproject/core/entity/DataPublicationType.java b/src/main/java/org/icatproject/core/entity/DataPublicationType.java
@@ -4,15 +4,15 @@
 import java.util.ArrayList;
 import java.util.List;
 
-import javax.persistence.CascadeType;
-import javax.persistence.Column;
-import javax.persistence.Entity;
-import javax.persistence.FetchType;
-import javax.persistence.JoinColumn;
-import javax.persistence.ManyToOne;
-import javax.persistence.OneToMany;
-import javax.persistence.Table;
-import javax.persistence.UniqueConstraint;
+import jakarta.persistence.CascadeType;
+import jakarta.persistence.Column;
+import jakarta.persistence.Entity;
+import jakarta.persistence.FetchType;
+import jakarta.persistence.JoinColumn;
+import jakarta.persistence.ManyToOne;
+import jakarta.persistence.OneToMany;
+import jakarta.persistence.Table;
+import jakarta.persistence.UniqueConstraint;
 
 @Comment("A type of data publication, for example, whole investigation, user-selected datasets/files. "
 		+ "This is likely to be for facility internal purposes following their own classification "