Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The logic for computing vmin and vmax for an archive is not trivial. The logic for computing each of vmin and vmax depends on factors including:
Currently, the logic for handling vmin and vmax is repeated across all the functions in
ribs/visualize, and there are gaps for the cases where vmin is None and vmax is not None, and vice versa. This PR fills in that logic and moves it into a common utility inribs/visualize/_utils.py.TODO
compute_vmin_vmaxutil inribs/visualize/_utils.pytests/utils/utils_test.pyribs/visualize/to use the new utiltest_vmin_equals_vmaxchanged for both these functionsStatus
CONTRIBUTING.md
ruffandpylintpytestHISTORY.md