Conversation
Member
|
I compared this branch against my branch, and I manually modified some additional files: The two valve models are not found by the regexp, because they have DynamicSelect(). |
Contributor
Author
|
@thorade : Thanks for catching these additional changes. If you are OK with the changes, can you please approve the PR so it will auto merge. |
thorade
approved these changes
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #2080
The changes were applied with the script of lbl-srg/modelica-buildings#4456 (comment)
Also, the github workflow is now checking for old annotations, using the commands of the above script, and will fail if it finds old annotations.
@thorade : Can you please review the changes. Thanks for the regex, which helped automating it and adding it to the CI testing.