Conversation
|
@mwetter: I do not understand why the CI fails for IBPSA.Electrical.DC.Sources.Validation.PVSingleDiodeRooftopBuildingValidation since the "Simulate and Plot" script works fine on my desktop. |
|
@LauraMaier Running the model
|
|
@LauraMaier In the same file, the expressions RSh/RSh0 = 1/max(absRadRat, Modelica.Constants.eps);
// Simplified power correlations at MPP using Lambert W function (Batzelis et al., 2016)
IMP = max(0,IPh*(1 - 1/w) - a*(w - 1)/max(Modelica.Constants.eps, RSh));can be rewritten without regularization. The problem in the original formulation is that I added these changes in 8421baa80 together with some other changes further down in that file, but now I am stuck: If Also, please correct the unit error that @JayHuLBL pointed out so the regression tests run and we can make sure that we don't introduce an error when making these changes. |
Thanks for comment. Adressed @JayHuLBL's comment in commit aee2cfc |
Thanks for your support, @mwetter. |
|
@mwetter and @JayHuLBL : Again, models look fine with Dymola 2023. I cannot update to the latest Dymola version since I am no longer employed at the university. Can you maybe share the error log since I cannot find it in the CI and cannot reproduce it locally since everything runs smoothly here. Thanks for the support! |
I will test it and let you know if there is any problem. |
|
@LauraMaier All the models can run successfully with Dymola 2025x. I have run the unit test and pushed the reference data. |
@JayHuLBL : Many thanks for your valuable support. I added some minor adjustment for OM compatibility. |
There was a problem hiding this comment.
@LauraMaier I did some changes to modify the format and appearance of the models. Also:
-
IBPSA.Electrical.BaseClasses.PV.PVThermalEmpMountContactToGroundis not used by any class. Do we need it? -
IBPSA.Electrical.BaseClasses.PV.PVThermalEmpMountOpenRackis not used by any class. Do we need it? - In
IBPSA.Electrical.BaseClasses.PV.BaseClasses.PartialPVOptical, how is the inputtilSetbeing used? Although the base classPV.BaseClasses.PartialPVOpticalis used byIBPSA.Electrical.BaseClasses.PV.PVOpticalAbsRatandIBPSA.Electrical.BaseClasses.PV.PartialPVSystem, I don’t seetilSetbeing needed. - Has the image
Resources/Images/Electrical/AC/OnePhase/Storage/Examples/SOCs.pngbeen used anywhere? Otherwise, it should be deleted.
|
Thank you so much, @JayHuLBL !
|


This closes #1575
We added a new PV model to the IBPSA library.
The model has the following characteristics: