Add support for ReadyToRemove interface#186
Add support for ReadyToRemove interface#186abiasojo wants to merge 1 commit intoibm-openbmc:1120from
Conversation
|
Can one of the admins verify this patch? |
jeaaustx
left a comment
jeaaustx
left a comment
There was a problem hiding this comment.
Please add detail to PR description and to the commit message itself.
For upstream will probably need commit message to describe why this option is being added and what it would be used for.
| @@ -0,0 +1,9 @@ | |||
| description: > | |||
| An indication of whether the inventory is prepared by the system for | |||
There was a problem hiding this comment.
nit: Seems like more common term would be "inventory item".
| @@ -0,0 +1,9 @@ | |||
| description: > | |||
| An indication of whether the inventory is prepared by the system for | |||
There was a problem hiding this comment.
nit: Interface description seems like it is usually termed as "Implement to..."
(this description reads more like the actual property description).
| - name: ReadyToRemove | ||
| type: boolean | ||
| description: > | ||
| An indication of whether the item is prepared by the system for |
There was a problem hiding this comment.
Question: Is this readonly? If not, then I'm wondering about this description. If the property is set to false versus set to true by something?
(The description as written seems to be about what a query of this property would indicate.)
|
add to approvelist |
abiasojo
force-pushed
the
1120-Readtoremove
branch
from
5145d4e to
00ebe9e
Compare
|
Let's give this a week or two upstream before we take it downstream |
abiasojo
force-pushed
the
1120-Readtoremove
branch
from
00ebe9e to
3703bb8
Compare
|
Please add
-- |
abiasojo
force-pushed
the
1120-Readtoremove
branch
from
3703bb8 to
6c4557e
Compare
|
I would suggest to wait on this until we conclude the Concurrent Maintenance backend design. Is there anything else at bmcweb which needs this dbus interface early? |
This new D-Bus interface is implemented to indicate whether the item is prepared by the system for removal. Setting the value to true shall cause the service to perform appropriate actions to quiesce the item. ReadyToRemove is already on the Redfish Drive and PCIeDevice resource. ReadyToRemove was added to Redfish Manager, Redfish Assembly, and Redfish Chassis in 2025.3. [1] IBM plans to use ReadyToRemove for redundant BMCs. This ReadyToRemove is part of IBM's Concurrent maintenance ``` [1]https://www.dmtf.org/sites/default/files/standards/documents/DSP0268_2025.3.pdf ``` Change-Id: I5c50f8792d968e3427e64ebf99a2fc5f32aaa87a Signed-off-by: Abiola Asojo <abiola.asojo@ibm.com>
abiasojo
force-pushed
the
1120-Readtoremove
branch
from
6c4557e to
348ed76
Compare
The bmcweb work could start as soon as this interface goes in, but I would suggest we keep going upstream with it. |
6 participants
Add support for ReadyToRemove interface.