vpd-manager:Check for essential FRUs#524
Draft
PriyangaRamasamy wants to merge 1 commit intoibm-openbmc:1110_Devfrom
Draft
vpd-manager:Check for essential FRUs#524PriyangaRamasamy wants to merge 1 commit intoibm-openbmc:1110_Devfrom
PriyangaRamasamy wants to merge 1 commit intoibm-openbmc:1110_Devfrom
Conversation
This commit implements an API to check if all the essential FRUs are present on the system. If not error is logged. Test: 1. Essential FRU not found busctl set-property xyz.openbmc_project.Inventory.Manager /xyz/openbmc_project/inventory/system/chassis/motherboard/base_op_panel_blyth xyz.openbmc_project.Inventory.Item Present b false vpd-manager[1577]: FileName: /usr/src/debug/openpower-fru-vpd/1.0+git/ vpd-manager/src/manager.cpp, Line: 884, Func: void vpd::Manager::checkEssentialFrus(), Essential FRU /xyz/openbmc_project/ inventory/system/chassis/motherboard/base_op_panel_blyth not present. Change-Id: Ibeba4b9064907a7751c6ed3ec79b966fa44feca9 Signed-off-by: Priyanga Ramasamy <priyanga24@in.ibm.com>
PriyangaRamasamy
requested review from
RekhaAparna01,
SunnySrivastava1984,
branupama,
jinuthomas and
souvik1914581
Author
|
Will hold this PR until we get a requirement to have essential FRU check in 1110 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements an API to check if all the essential FRUs are present on the system. If not error is logged.
Test:
vpd-manager[1577]: FileName: /usr/src/debug/openpower-fru-vpd/1.0+git/ vpd-manager/src/manager.cpp, Line: 884, Func: void vpd::Manager::checkEssentialFrus(), Essential FRU /xyz/openbmc_project/ inventory/system/chassis/motherboard/base_op_panel_blyth not present.
Change-Id: Ibeba4b9064907a7751c6ed3ec79b966fa44feca9