This repository has been archived by the owner on Jul 28, 2021. It is now read-only.
Bug fix: Avoid setting KeySet with an empty JWKS URL #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt to always use the JWKS URL from the discovery if available This should prevent the following error due to empty JWKS URL: "Failed to retrieve public keys", "url":"","error":"Get : unsupported protocol scheme \"\""
devstein
approved these changes
Feb 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to always use the JWKS URL from the discovery if available.
This should prevent the following error due to empty JWKS URL:
"Failed to retrieve public keys", "url":"","error":"Get : unsupported protocol scheme """
That error means JWKS URL in the KeySet object was an empty string.
It could easily happen if discovery endpoint failed during add/update of OidcConfig CRD. Even if there was a valid KeySet with a valid JWKS URL before, discovery endpoint failure during add/update would overwrite this valid KeySet with a new KeySet containing an empty string for JWKS URL.
Note that add/update operation also happens on adapter startup or after Kubernetes API starts being available after a temporary downtime so this bad overwrite can happen any time discovery endpoint is unable to respond at the time add/update handler for OidcConfig is called.