This repository has been archived by the owner on Jul 28, 2021. It is now read-only.
Fix path join issue for the callback url #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devstein
approved these changes
Feb 13, 2020
devstein
previously approved these changes
Mar 4, 2020
|
@canthefason Please create a PR on the development branch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callback URL includes an additional slash when the the path is '/' for an OIDC policy. This ends up with producing an invalid redirect url. One such example is this following url:
https://example.com//oidc/callbackThis PR strips that additional slash by using path.Join instead of a straight concatenation.