Merge pull request #150 from ibis-ssl/refactor/pre-commit

pre-commit色々

.clang-format

@@ -1,4 +1,3 @@
----
 Language: Cpp
 BasedOnStyle: Google
 

.github/dependabot.yml

@@ -1,12 +1,10 @@
-# To get started with Dependabot version updates, you'll need to specify which
-# package ecosystems to update and where the package manifests are located.
-# Please see the documentation for all configuration options:
-# https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
-
 version: 2
 updates:
-  - package-ecosystem: "" # See documentation for possible values
-    directory: "/" # Location of package manifests
+  - package-ecosystem: github-actions
+    directory: /
     schedule:
-      interval: "weekly"
-
+      interval: daily
+      open-pull-requests-limit: 1
+      labels:
+        - tag:bot
+        - type:github-actions

.github/workflows/build_test.yaml

@@ -1,19 +1,17 @@
----
 name: build test
 
 on:
   workflow_dispatch:
   pull_request:
     paths:
-      - '.github/workflows/build-test.yml'
-      - '**/**.cpp'
-      - '**/**.h'
-      - '**/**.hpp'
-      - '**/CMakeLists.txt'
-      - '**/package.xml'
+      - .github/workflows/build-test.yml
+      - "**/**.cpp"
+      - "**/**.h"
+      - "**/**.hpp"
+      - "**/CMakeLists.txt"
+      - "**/package.xml"
   merge_group:
 
-
 jobs:
   job:
     name: BuildAndRun
@@ -75,7 +73,7 @@ jobs:
 
       - name: Setup Problem Matchers for clang-format
         run: echo "::add-matcher::${{ github.workspace }}/.github/matchers/clang-format.json"
-        
+
       - name: Show test result
         if: always()
         run: |

.github/workflows/custom_dict.json

@@ -1,7 +1,5 @@
 {
-  "ignorePaths": [
-    "**/**.ui"
-  ],
+  "ignorePaths": ["**/**.ui"],
   "words": [
     "grSim",
     "robocup",

.github/workflows/sync_doc.yaml

@@ -1,12 +1,11 @@
----
 name: sync docs
 on:
   push:
     branches:
       - develop
       - master
     paths:
-      - "docs/**"
+      - docs/**
 
   workflow_dispatch:
 

.markdownlint.yaml

@@ -0,0 +1,10 @@
+default: true
+MD013: false
+MD024:
+  siblings_only: true
+MD029:
+  style: ordered
+MD033: false
+MD041: false
+MD046: false
+MD049: false

.pre-commit-config.yaml

@@ -1,4 +1,3 @@
----
 ci:
   autofix_commit_msg: "style(pre-commit): autofix"
 
@@ -24,10 +23,10 @@ repos:
       - id: markdownlint
         args: [-c, .markdownlint.yaml, --fix]
 
-  - repo: https://github.com/pre-commit/mirrors-prettier
-    rev: v3.0.0-alpha.6
-    hooks:
-      - id: prettier
+#  - repo: https://github.com/pre-commit/mirrors-prettier
+#    rev: v3.0.0-alpha.6
+#    hooks:
+#      - id: prettier
 
   - repo: https://github.com/adrienverge/yamllint
     rev: v1.30.0
@@ -37,7 +36,7 @@ repos:
   - repo: https://github.com/tier4/pre-commit-hooks-ros
     rev: v0.8.0
     hooks:
-      - id: flake8-ros
+      #      - id: flake8-ros
       - id: prettier-xacro
       - id: prettier-launch-xml
       - id: prettier-package-xml
@@ -55,16 +54,16 @@ repos:
       - id: shfmt
         args: [-w, -s, -i=4]
 
-  - repo: https://github.com/pycqa/isort
-    rev: 5.12.0
-    hooks:
-      - id: isort
+#  - repo: https://github.com/pycqa/isort
+#    rev: 5.12.0
+#    hooks:
+#      - id: isort
 
   - repo: https://github.com/psf/black
     rev: 23.3.0
     hooks:
       - id: black
-        args: [--line-length=100]
+        args: [--line-length=99]
 
   - repo: https://github.com/pre-commit/mirrors-clang-format
     rev: v16.0.0

.vscode/settings.json

@@ -1,18 +1,18 @@
 {
-    "python.autoComplete.extraPaths": [
-        "/home/hans/workspace/ibis_ws/install/robocup_ssl_msgs/local/lib/python3.10/dist-packages",
-        "/home/hans/workspace/ibis_ws/install/crane_msgs/local/lib/python3.10/dist-packages",
-        "/home/hans/workspace/ibis_ws/install/crane_description/local/lib/python3.10/dist-packages",
-        "/home/hans/workspace/ibis_ws/install/consai_visualizer/local/lib/python3.10/dist-packages",
-        "/opt/ros/humble/lib/python3.10/site-packages",
-        "/opt/ros/humble/local/lib/python3.10/dist-packages"
-    ],
-    "python.analysis.extraPaths": [
-        "/home/hans/workspace/ibis_ws/install/robocup_ssl_msgs/local/lib/python3.10/dist-packages",
-        "/home/hans/workspace/ibis_ws/install/crane_msgs/local/lib/python3.10/dist-packages",
-        "/home/hans/workspace/ibis_ws/install/crane_description/local/lib/python3.10/dist-packages",
-        "/home/hans/workspace/ibis_ws/install/consai_visualizer/local/lib/python3.10/dist-packages",
-        "/opt/ros/humble/lib/python3.10/site-packages",
-        "/opt/ros/humble/local/lib/python3.10/dist-packages"
-    ]
-}
+  "python.autoComplete.extraPaths": [
+    "/home/hans/workspace/ibis_ws/install/robocup_ssl_msgs/local/lib/python3.10/dist-packages",
+    "/home/hans/workspace/ibis_ws/install/crane_msgs/local/lib/python3.10/dist-packages",
+    "/home/hans/workspace/ibis_ws/install/crane_description/local/lib/python3.10/dist-packages",
+    "/home/hans/workspace/ibis_ws/install/consai_visualizer/local/lib/python3.10/dist-packages",
+    "/opt/ros/humble/lib/python3.10/site-packages",
+    "/opt/ros/humble/local/lib/python3.10/dist-packages"
+  ],
+  "python.analysis.extraPaths": [
+    "/home/hans/workspace/ibis_ws/install/robocup_ssl_msgs/local/lib/python3.10/dist-packages",
+    "/home/hans/workspace/ibis_ws/install/crane_msgs/local/lib/python3.10/dist-packages",
+    "/home/hans/workspace/ibis_ws/install/crane_description/local/lib/python3.10/dist-packages",
+    "/home/hans/workspace/ibis_ws/install/consai_visualizer/local/lib/python3.10/dist-packages",
+    "/opt/ros/humble/lib/python3.10/site-packages",
+    "/opt/ros/humble/local/lib/python3.10/dist-packages"
+  ]
+}

.yamllint.yaml

@@ -0,0 +1,22 @@
+extends: default
+
+ignore: |
+  *.param.yaml
+
+rules:
+  braces:
+    level: error
+    max-spaces-inside: 1 # To format with Prettier
+  comments:
+    level: error
+    min-spaces-from-content: 1 # To be compatible with C++ and Python
+  document-start:
+    level: error
+    present: false # Don't need document start markers
+  line-length: disable # Delegate to Prettier
+  truthy:
+    level: error
+    check-keys: false # To allow 'on' of GitHub Actions
+  quoted-strings:
+    level: error
+    required: only-when-needed # To keep consistent style

CPPLINT.cfg

@@ -0,0 +1,15 @@
+# Modified from https://github.com/ament/ament_lint/blob/ebd524bb9973d5ec1dc48a670ce54f958a5a0243/ament_cpplint/ament_cpplint/main.py#L64-L120
+set noparent
+linelength=100
+includeorder=standardcfirst
+filter=-build/c++11               # we do allow C++11
+filter=-build/namespaces_literals # we allow using namespace for literals
+filter=-runtime/references        # we consider passing non-const references to be ok
+filter=-whitespace/braces         # we wrap open curly braces for namespaces, classes and functions
+filter=-whitespace/indent         # we don't indent keywords like public, protected and private with one space
+filter=-whitespace/parens         # we allow closing parenthesis to be on the next line
+filter=-whitespace/semicolon      # we allow the developer to decide about whitespace after a semicolon
+filter=-build/header_guard        # we automatically fix the names of header guards using pre-commit
+filter=-build/include_order       # we use the custom include order
+filter=-build/include_subdir      # we allow the style of "foo.hpp"
+filter=-readability/alt_tokens    # we want to use not instead of !

consai_ros2/consai_vision_tracker/package.xml

@@ -9,13 +9,13 @@
 
   <buildtool_depend>ament_cmake_auto</buildtool_depend>
 
+  <depend>consai_visualizer_msgs</depend>
   <depend>launch_ros</depend>
   <depend>liborocos-bfl</depend>
   <depend>pkg-config</depend>
   <depend>rclcpp</depend>
   <depend>rclcpp_components</depend>
   <depend>robocup_ssl_msgs</depend>
-  <depend>consai_visualizer_msgs</depend>
 
   <test_depend>ament_lint_auto</test_depend>
   <test_depend>crane_lint_common</test_depend>

consai_ros2/consai_vision_tracker/src/tracker_component.cpp

@@ -23,15 +23,14 @@
 
 #include "robocup_ssl_msgs/msg/robot_id.hpp"
 
-using namespace std::chrono_literals;
-
 namespace consai_vision_tracker
 {
 using RobotId = robocup_ssl_msgs::msg::RobotId;
 using std::placeholders::_1;
 
 Tracker::Tracker(const rclcpp::NodeOptions & options) : Node("tracker", options)
 {
+  using std::chrono::operator""s;
   const auto UPDATE_RATE = 0.01s;
 
   ball_tracker = std::make_shared<BallTracker>(UPDATE_RATE.count());